Skip to content

Conversation

@JoshRosen
Copy link
Contributor

This upgrades snappy-java to 1.1.1.6, which includes a patch that improves error messages when attempting to deserialize empty inputs using SnappyInputStream (see xerial/snappy-java#89).

We previously tried up upgrade to 1.1.1.5 in #2911 but reverted that patch after discovering a memory leak in snappy-java. This should leak have been fixed in 1.1.1.6, though (see xerial/snappy-java#92).

We previously tried up upgrade to 1.1.1.5 in apache#2911 but reverted that
patch after discovering a memory leak in snappy-java.  This should
leak have been fixed in 1.1.1.6, though.
@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23426 has started for PR 3287 at commit 5d6f4cc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23426 timed out for PR 3287 at commit 5d6f4cc after a configured wait of 120m.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23426/
Test FAILed.

@JoshRosen
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23428 has started for PR 3287 at commit 5d6f4cc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23428 has finished for PR 3287 at commit 5d6f4cc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23428/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Nov 16, 2014

Merging in master & branch-1.2.

@asfgit asfgit closed this in 7d8e152 Nov 16, 2014
asfgit pushed a commit that referenced this pull request Nov 16, 2014
This upgrades snappy-java to 1.1.1.6, which includes a patch that improves error messages when attempting to deserialize empty inputs using SnappyInputStream (see xerial/snappy-java#89).

We previously tried up upgrade to 1.1.1.5 in #2911 but reverted that patch after discovering a memory leak in snappy-java.  This should leak have been fixed in 1.1.1.6, though (see xerial/snappy-java#92).

Author: Josh Rosen <[email protected]>

Closes #3287 from JoshRosen/SPARK-4419 and squashes the following commits:

5d6f4cc [Josh Rosen] [SPARK-4419] Upgrade snappy-java to 1.1.1.6.

(cherry picked from commit 7d8e152)
Signed-off-by: Reynold Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants