[SPARK-35693][SS][TEST] Add plan check for stream-stream join unit test #32836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan (original author) if you have time to take a look, thanks. |
Contributor
Author
|
Close & Reopen PR to trigger unit test on github action again. |
cloud-fan
approved these changes
Jun 9, 2021
Contributor
Author
|
Rebased to latest master. |
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #139549 has finished for PR 32836 at commit
|
|
Kubernetes integration test starting |
|
Test build #139559 has finished for PR 32836 at commit
|
Contributor
|
thanks, merging to master! |
|
Kubernetes integration test status failure |
Contributor
Author
|
Thank you @cloud-fan for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The changed unit test was introduce in #21587, to fix the planner side of thing for stream-stream join. Ideally check the query result should catch the bug, but it would be better to add plan check to make the purpose of unit test more clearly and catch future bug from planner change.
Why are the changes needed?
Improve unit test.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Changed test itself.