Skip to content

[SQL] Minor cleanup of comments, errors and override. #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SQL] Minor cleanup of comments, errors and override. #3257

wants to merge 4 commits into from

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Nov 13, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 13, 2014

Test build #23336 has started for PR 3257 at commit 2fdf903.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23336 has finished for PR 3257 at commit 2fdf903.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23336/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23353 has started for PR 3257 at commit d8b5abc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 14, 2014

Test build #23353 has finished for PR 3257 at commit d8b5abc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 14, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23353/
Test PASSed.

asfgit pushed a commit that referenced this pull request Nov 14, 2014
@marmbrus
[SQL] Minor cleanup of comments, errors and override.
e35672e 
Author: Michael Armbrust <[email protected]>

Closes #3257 from marmbrus/minorCleanup and squashes the following commits:

d8b5abc [Michael Armbrust] Use interpolation.
2fdf903 [Michael Armbrust] Better error message when coalesce can't be resolved.
f9fa6cf [Michael Armbrust] Methods in a final class do not also need to be final, use override.
199fd98 [Michael Armbrust] Fix typo

(cherry picked from commit f805025)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in f805025 Nov 14, 2014
@marmbrus marmbrus deleted the minorCleanup branch November 19, 2014 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @AmplabJenkins