Skip to content

[branch-1.1][SPARK-4355] OnlineSummarizer doesn't merge mean correctly #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[branch-1.1][SPARK-4355] OnlineSummarizer doesn't merge mean correctly #3251

wants to merge 2 commits into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 13, 2014

@andrewor14 This backports the bug fix in #3220 . It would be good if we can get it in 1.1.1. But this is minor.

@SparkQA
Copy link

SparkQA commented Nov 13, 2014

QA tests have started for PR 3251 at commit 33886b6.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 13, 2014

QA tests have finished for PR 3251 at commit 33886b6.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 13, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23318/
Test PASSed.

@andrewor14
Copy link
Contributor

andrewor14 commented Nov 13, 2014

Feel free to merge this if this LGTY. By the way the protocol we have is to set the fixed version of the issue to 1.1.2 because it might not make it into the current RC. If we need to cut another RC later we can change the fix version back to 1.1.1.

@mengxr
Copy link
Contributor Author

mengxr commented Nov 13, 2014

Okay. Merged.

@mengxr mengxr closed this Nov 14, 2014
asfgit pushed a commit that referenced this pull request Nov 14, 2014
@mengxr
[branch-1.1][SPARK-4355] OnlineSummarizer doesn't merge mean correctly
4b1c77c 
andrewor14 This backports the bug fix in #3220 . It would be good if we can get it in 1.1.1. But this is minor.

Author: Xiangrui Meng <[email protected]>

Closes #3251 from mengxr/SPARK-4355-1.1 and squashes the following commits:

33886b6 [Xiangrui Meng] Merge remote-tracking branch 'apache/branch-1.1' into SPARK-4355-1.1
91fe1a3 [Xiangrui Meng] fix OnlineSummarizer.merge when other.mean is zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @SparkQA @AmplabJenkins @andrewor14