[SPARK-4205][SQL] DSL expressions with a literal on the left hand side #3210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the DSL expression parser does not recognize expressions which begin with a literal, such as:
0 < 'x.This PR adds a new implicit class which allows such expressions to be included in the DSL. Due to conflicts with scalatest, which converts
===and!==in itsassertmacro, these two operators can not be used by the new class. It adds two new operators-=-and!=-which behave identically to===and!==within the DSL, but can also be used in expressions which start with a literal.The new class replaces the comment:
// TODO more implicit class for literal?I think this may be what the author had in mind.