Skip to content

Conversation

@culler
Copy link

@culler culler commented Nov 11, 2014

Currently the DSL expression parser does not recognize expressions which begin with a literal, such as:
0 < 'x.

This PR adds a new implicit class which allows such expressions to be included in the DSL. Due to conflicts with scalatest, which converts === and !== in its assert macro, these two operators can not be used by the new class. It adds two new operators -=- and !=- which behave identically to === and !== within the DSL, but can also be used in expressions which start with a literal.

The new class replaces the comment: // TODO more implicit class for literal?
I think this may be what the author had in mind.

@culler
Copy link
Author

culler commented Nov 11, 2014

@marmbrus and @liancheng, here is the other half of PR #3158.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

@culler, thanks for working on this. I'm concerned about having too many implicates in scope at any given time and so I'm hesitant to add this (especially as the default set included in the sqlContext). As a result, I propose we close this issue for now and consider some smaller improvements to the DSL.

@asfgit asfgit closed this in ca12608 Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants