[SPARK-34951][INFRA][PYTHON][TESTS] Set the system encoding as UTF-8 to recover the Sphinx build in GitHub Actions #32047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Can you take a quick look please when you guys find some time? |
HyukjinKwon
changed the title
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
viirya
approved these changes
Apr 4, 2021
viirya
reviewed
Apr 4, 2021
Comment on lines
-360
to
-361
| export LC_ALL=C.UTF-8 | ||
| export LANG=C.UTF-8 |
Member
There was a problem hiding this comment.
interesting, so export doesn't work?
Member
Author
There was a problem hiding this comment.
Oh it works. Problem was that we didn't set both when we run lint-python above that trigfers sphinx build ..
Member
There was a problem hiding this comment.
I guess we need this still.
| runs-on: ubuntu-20.04 | ||
| env: | ||
| LC_ALL: C.UTF-8 | ||
| LANG: C.UTF-8 |
Member
There was a problem hiding this comment.
Ur, interesting. Previously, I moved this from here to line 360 because the linter is executed inside dongjoon/apache-spark-github-action-image:20201025.
Member
|
Anyway, if this passes GA, please proceed to merge. Thank you always, @HyukjinKwon ! |
|
Test build #136889 has finished for PR 32047 at commit
|
MaxGekk
pushed a commit
that referenced
this pull request
Apr 4, 2021
…tion ### What changes were proposed in this pull request? This PR replaces the non-ASCII characters to ASCII characters when possible in PySpark documentation ### Why are the changes needed? To avoid unnecessarily using other non-ASCII characters which could lead to the issue such as #32047 or #22782 ### Does this PR introduce _any_ user-facing change? Virtually no. ### How was this patch tested? Found via (Mac OS): ```bash # In Spark root directory cd python pcregrep --color='auto' -n "[\x80-\xFF]" `git ls-files .` ``` Closes #32048 from HyukjinKwon/minor-fix. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Member
Author
|
Merged to master, branch-3.1 and branch-3.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Apr 4, 2021
…to recover the Sphinx build in GitHub Actions This PR proposes to set the system encoding as UTF-8. For some reasons, it looks like GitHub Actions machines changed theirs to ASCII by default. This leads to default encoding/decoding to use ASCII in Python, e.g.) `"a".encode()`, and looks like Sphinx depends on that. To recover GItHub Actions build. No, dev-only. Tested in #32046 Closes #32047 from HyukjinKwon/SPARK-34951. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 82ad2f9) Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon
added a commit
that referenced
this pull request
Apr 4, 2021
…to recover the Sphinx build in GitHub Actions This PR proposes to set the system encoding as UTF-8. For some reasons, it looks like GitHub Actions machines changed theirs to ASCII by default. This leads to default encoding/decoding to use ASCII in Python, e.g.) `"a".encode()`, and looks like Sphinx depends on that. To recover GItHub Actions build. No, dev-only. Tested in #32046 Closes #32047 from HyukjinKwon/SPARK-34951. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 82ad2f9) Signed-off-by: HyukjinKwon <[email protected]>
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…to recover the Sphinx build in GitHub Actions This PR proposes to set the system encoding as UTF-8. For some reasons, it looks like GitHub Actions machines changed theirs to ASCII by default. This leads to default encoding/decoding to use ASCII in Python, e.g.) `"a".encode()`, and looks like Sphinx depends on that. To recover GItHub Actions build. No, dev-only. Tested in apache#32046 Closes apache#32047 from HyukjinKwon/SPARK-34951. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit 82ad2f9) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to set the system encoding as UTF-8. For some reasons, it looks like GitHub Actions machines changed theirs to ASCII by default. This leads to default encoding/decoding to use ASCII in Python, e.g.)
"a".encode(), and looks like Sphinx depends on that.Why are the changes needed?
To recover GItHub Actions build.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
Tested in #32046