[SPARK-34415][ML] Python example. #31687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Feb 28, 2021
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks good. I'll merge when the tests pass.
Member
|
Jenkins test this please |
|
Test build #135568 has finished for PR 31687 at commit
|
Member
|
Merged to master to fix the linter. Thanks! |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
Member
|
+1, LGTM. Thank you, @PhillHenry and @srowen . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing Python example file for [SPARK-34415][ML] Randomization in hyperparameter optimization
(#31535)
What changes were proposed in this pull request?
For some reason (probably me being silly) a examples/src/main/python/ml/model_selection_random_hyperparameters_example.py was not pushed in a previous PR.
This PR restores that file.
Why are the changes needed?
A single file (examples/src/main/python/ml/model_selection_random_hyperparameters_example.py) that should have been pushed as part of SPARK-34415 but was not. This was causing Lint errors as highlighted by @dongjoon-hyun. Consequently, @srowen asked for a new PR.
Does this PR introduce any user-facing change?
No, it merely restores a file that was overlook in SPARK-34415.
How was this patch tested?
By running:
bin/spark-submit examples/src/main/python/ml/model_selection_random_hyperparameters_example.py