-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-34366][SQL] Add interface for DS v2 metrics #31476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
623f193
Add interface for DS v2 metrics.
viirya 89e2f3d
Modify comment.
viirya 38fb966
Make new interfaces.
viirya 00842c4
Go back to optional methods.
viirya b8c762a
Enrich metric comment.
viirya cce58a5
Move value method to CustomMetric.
viirya f46b733
Update.
viirya eb9d94a
Update comment.
viirya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
sql/catalyst/src/main/java/org/apache/spark/sql/connector/CustomMetric.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
|
|
||
| /** | ||
| * A custom metric. Data source can define supported custom metrics using this interface. | ||
| * During query execution, Spark will collect the task metrics using {@link CustomTaskMetric} | ||
| * and combine the metrics at the driver side. How to combine task metrics is defined by the | ||
| * metric class with the same metric name. | ||
| * | ||
| * @since 3.2.0 | ||
| */ | ||
| @Evolving | ||
| public interface CustomMetric { | ||
| /** | ||
| * Returns the name of custom metric. | ||
| */ | ||
| String name(); | ||
|
|
||
| /** | ||
| * Returns the description of custom metric. | ||
| */ | ||
| String description(); | ||
|
|
||
| /** | ||
| * The initial value of this metric. | ||
| */ | ||
| long initialValue = 0L; | ||
|
|
||
| /** | ||
| * Given an array of task metric values, returns aggregated final metric value. | ||
| */ | ||
| String aggregateTaskMetrics(long[] taskMetrics); | ||
| } | ||
46 changes: 46 additions & 0 deletions
46
sql/catalyst/src/main/java/org/apache/spark/sql/connector/CustomTaskMetric.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
| import org.apache.spark.sql.connector.read.PartitionReader; | ||
|
|
||
| /** | ||
| * A custom task metric. This is a logical representation of a metric reported by data sources | ||
| * at the executor side. During query execution, Spark will collect the task metrics per partition | ||
| * by {@link PartitionReader} and update internal metrics based on collected metric values. | ||
| * For streaming query, Spark will collect and combine metrics for a final result per micro batch. | ||
| * | ||
| * The metrics will be gathered during query execution back to the driver and then combined. How | ||
| * the task metrics are combined is defined by corresponding {@link CustomMetric} with same metric | ||
| * name. The final result will be shown up in the data source scan operator in Spark UI. | ||
| * | ||
| * @since 3.2.0 | ||
| */ | ||
| @Evolving | ||
| public interface CustomTaskMetric { | ||
| /** | ||
| * Returns the name of custom task metric. | ||
| */ | ||
| String name(); | ||
|
|
||
| /** | ||
| * Returns the long value of custom task metric. | ||
| */ | ||
| long value(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@viirya do we need this? It's not used anywhere and people can easily define their own initial value in the implementation of
CustomTaskMetric.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, we don't use this initial value at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove it.