-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-34339][CORE][SQL] Expose the number of total paths in Utils.buildLocationMetadata() #31464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
While I've marked SPARK-34339 as improvement, I also feel this may be considered as a bug, as the new output brought by SPARK-31793 brings confusion. |
|
cc.ing @gengliangwang @cloud-fan @HyukjinKwon @maropu who are author/reviewers of #28610 |
|
Yeah, I think this is better |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #134849 has finished for PR 31464 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Appreciate another round of review based on the changed output. I'll try out alternative if the output doesn't look good for us. Thanks! |
|
Hmm... I'll need to fix the test as a lot of tests are relying on the previous format ( |
|
Test build #134853 has finished for PR 31464 at commit
|
|
I was wrong about the amount of broken UTs. They were just 2 and I just fixed. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #134861 has finished for PR 31464 at commit
|
|
@HyukjinKwon @cloud-fan @gengliangwang Appreciate another round of review. Thanks! |
|
Merged to master. |
|
Thanks all for reviewing and merging! |
What changes were proposed in this pull request?
This PR proposes to expose the number of total paths in Utils.buildLocationMetadata(), with relaxing space usage a bit (around 10+ chars).
Suppose the first 2 of 5 paths are only fit to the threshold, the outputs between the twos are below:
[path1, path2](5 paths)[path1, path2, ...]Why are the changes needed?
SPARK-31793 silently truncates the paths hence end users can't indicate how many paths are truncated, and even more, whether paths are truncated or not.
Does this PR introduce any user-facing change?
Yes, the location metadata will also show how many paths are truncated (not shown), instead of silently truncated.
How was this patch tested?
Modified UTs