[SPARK-33212][FOLLOW-UP][BUILD] Fix test "built-in Hadoop version should support shaded client" for hadoop-2.7 #31391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld support shaded client" for hadoop-2.7
Contributor
sunchao
approved these changes
Jan 29, 2021
Member
sunchao
left a comment
sunchao
left a comment
There was a problem hiding this comment.
Oops sorry forgot about Hadoop 2.x. LGTM (non-binding) - thanks!
|
Can one of the admins verify this patch? |
HyukjinKwon
approved these changes
Jan 29, 2021
Member
|
add to whitelist |
Member
|
ok to test |
Member
|
Merged to master. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…uld support shaded client" for hadoop-2.7 ### What changes were proposed in this pull request? We added test "built-in Hadoop version should support shaded client" in apache#31203, but it fails when profile hadoop-2.7 is activated. This change fixes the test by skipping the assertion when Hadoop version is 2. ### Why are the changes needed? The test fails in master branch when profile hadoop-2.7 is activated. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Ran the test with hadoop-2.7 profile. Closes apache#31391 from bozhang2820/fix-hadoop-2-version-test. Authored-by: Bo Zhang <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
pan3793
pushed a commit
to pan3793/spark
that referenced
this pull request
Aug 30, 2021
…uld support shaded client" for hadoop-2.7 ### What changes were proposed in this pull request? We added test "built-in Hadoop version should support shaded client" in apache#31203, but it fails when profile hadoop-2.7 is activated. This change fixes the test by skipping the assertion when Hadoop version is 2. ### Why are the changes needed? The test fails in master branch when profile hadoop-2.7 is activated. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Ran the test with hadoop-2.7 profile. Closes apache#31391 from bozhang2820/fix-hadoop-2-version-test. Authored-by: Bo Zhang <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We added test "built-in Hadoop version should support shaded client" in #31203, but it fails when profile hadoop-2.7 is activated. This change fixes the test by skipping the assertion when Hadoop version is 2.
Why are the changes needed?
The test fails in master branch when profile hadoop-2.7 is activated.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Ran the test with hadoop-2.7 profile.