Skip to content

[SPARK-33934][SQL][FOLLOW-UP] Use SubProcessor's exit code as assert condition to fix flaky test #31046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[SPARK-33934][SQL][FOLLOW-UP] Use SubProcessor's exit code as assert condition to fix flaky test #31046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
03627c2
[SPARK-33934][SQL][FOLLOW-UP] Add SparkFile's root dir to env propert…
AngersZhuuuu Jan 5, 2021
1fbc91c
Update sql/core/src/test/resources/test_script.py
AngersZhuuuu Jan 6, 2021
19f124f
Empty
AngersZhuuuu Jan 6, 2021
7c2ce48
Empty
AngersZhuuuu Jan 6, 2021
e5cf288
Empty
AngersZhuuuu Jan 6, 2021
404fb63
Empty
AngersZhuuuu Jan 6, 2021
db12e28
Empty
AngersZhuuuu Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

package org.apache.spark.sql.execution

import java.io._
import java.io.{BufferedReader, File, InputStream, InputStreamReader, OutputStream}
Copy link
Member

@HyukjinKwon HyukjinKwon Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I don't know why I thought it's more than 5+. It's more than 6+ (https://github.com/databricks/scala-style-guide#imports).

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I don't know why I thought it's more than 5+. It's more than 6+ (https://github.com/databricks/scala-style-guide#imports).

Seems my local ideal's rule is 5, emmm I need to check this.

import java.nio.charset.StandardCharsets
import java.util.concurrent.TimeUnit

Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/resources/test_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#! /usr/bin/python
#!/usr/bin/env python3

# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
Expand Down
5 changes: 4 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/BaseScriptTransformationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,10 @@ abstract class BaseScriptTransformationSuite extends SparkPlanTest with SQLTestU
'd.cast("string"),
'e.cast("string")).collect())
}.getMessage
assert(e1.contains("Permission denied"))
// Check with status exit code since in GA test, it may lose detail failed root cause.
// Different root cause's exitcode is not same.
// In this test, root cause is `Permission denied`
assert(e1.contains("Subprocess exited with status 126"))

// test `/path/to/script.py' with script executable
scriptFilePath.setExecutable(true)
Expand Down