-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-34083][SQL] Using TPCDS original definitions for char/varchar columns #31012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,15 +128,15 @@ Input [9]: [ss_item_sk#1, ss_cdemo_sk#2, ss_store_sk#3, ss_quantity#4, ss_list_p | |
| Output [4]: [cd_demo_sk#13, cd_gender#14, cd_marital_status#15, cd_education_status#16] | ||
| Batched: true | ||
| Location [not included in comparison]/{warehouse_dir}/customer_demographics] | ||
| PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary), IsNotNull(cd_demo_sk)] | ||
| PushedFilters: [IsNotNull(cd_gender), IsNotNull(cd_marital_status), IsNotNull(cd_education_status), EqualTo(cd_gender,F), EqualTo(cd_marital_status,D), EqualTo(cd_education_status,Primary ), IsNotNull(cd_demo_sk)] | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No big deal at all, just wondering why this now has whitespace? is it because these are now fixed-length strings?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the |
||
| ReadSchema: struct<cd_demo_sk:int,cd_gender:string,cd_marital_status:string,cd_education_status:string> | ||
|
|
||
| (12) ColumnarToRow [codegen id : 2] | ||
| Input [4]: [cd_demo_sk#13, cd_gender#14, cd_marital_status#15, cd_education_status#16] | ||
|
|
||
| (13) Filter [codegen id : 2] | ||
| Input [4]: [cd_demo_sk#13, cd_gender#14, cd_marital_status#15, cd_education_status#16] | ||
| Condition : ((((((isnotnull(cd_gender#14) AND isnotnull(cd_marital_status#15)) AND isnotnull(cd_education_status#16)) AND (cd_gender#14 = F)) AND (cd_marital_status#15 = D)) AND (cd_education_status#16 = Primary)) AND isnotnull(cd_demo_sk#13)) | ||
| Condition : ((((((isnotnull(cd_gender#14) AND isnotnull(cd_marital_status#15)) AND isnotnull(cd_education_status#16)) AND (cd_gender#14 = F)) AND (cd_marital_status#15 = D)) AND (cd_education_status#16 = Primary )) AND isnotnull(cd_demo_sk#13)) | ||
|
|
||
| (14) Project [codegen id : 2] | ||
| Output [1]: [cd_demo_sk#13] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only non-testing change in this PR, but it's very minor and obvious.