[SPARK-33900][WEBUI] Show shuffle read size / records correctly when only remotebytesread is available #30916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
current: |
Member
|
ok to test. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #133352 has finished for PR 30916 at commit
|
Member
|
@cxzl25 Nice catch. Could you copy the screen shots to the description ? |
sarutak
approved these changes
Dec 24, 2020
asfgit
pushed a commit
that referenced
this pull request
Dec 24, 2020
…only remotebytesread is available ### What changes were proposed in this pull request? Shuffle Read Size / Records can also be displayed in remoteBytesRead>0 localBytesRead=0. current:  fix:  ### Why are the changes needed? At present, the page only displays the data of Shuffle Read Size / Records when localBytesRead>0. When there is only remote reading, metrics cannot be seen on the stage page. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? manual test Closes #30916 from cxzl25/SPARK-33900. Authored-by: sychen <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 700f5ab) Signed-off-by: Kousuke Saruta <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Dec 24, 2020
…only remotebytesread is available ### What changes were proposed in this pull request? Shuffle Read Size / Records can also be displayed in remoteBytesRead>0 localBytesRead=0. current:  fix:  ### Why are the changes needed? At present, the page only displays the data of Shuffle Read Size / Records when localBytesRead>0. When there is only remote reading, metrics cannot be seen on the stage page. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? manual test Closes #30916 from cxzl25/SPARK-33900. Authored-by: sychen <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]> (cherry picked from commit 700f5ab) Signed-off-by: Kousuke Saruta <[email protected]>
Member
|
Thanks @cxzl25 ! Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Shuffle Read Size / Records can also be displayed in remoteBytesRead>0 localBytesRead=0.
current:
fix:
Why are the changes needed?
At present, the page only displays the data of Shuffle Read Size / Records when localBytesRead>0.
When there is only remote reading, metrics cannot be seen on the stage page.
Does this PR introduce any user-facing change?
No
How was this patch tested?
manual test