[SPARK-33892][SQL] Display char/varchar in DESC and SHOW CREATE TABLE #30908
Conversation
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
cc @cloud-fan @maropu @HyukjinKwon thanks a lot |
| isExtended: Boolean) extends V2CommandExec { | ||
|
|
||
|
|
||
| override def producedAttributes: AttributeSet = outputSet |
There was a problem hiding this comment.
Shall we do this in V2CommandExec?
There was a problem hiding this comment.
Yea, I agree. I was wondering if it is relevant to this PR.
| } | ||
| } | ||
|
|
||
| test("DESCRIBE COLUMN w/ char/varchar") { |
There was a problem hiding this comment.
shall we add a TODO? eventually, v2 catalog can run these 2 commands as well.
There was a problem hiding this comment.
Any existing JIRA to track this, or I shall create one, then mark todo w/ it togeter
There was a problem hiding this comment.
|
Test build #133306 has finished for PR 30908 at commit
|
|
Test build #133317 has finished for PR 30908 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
| import org.apache.spark.sql.catalyst.InternalRow | ||
| import org.apache.spark.sql.catalyst.encoders.RowEncoder | ||
| import org.apache.spark.sql.catalyst.expressions.{Attribute, GenericRowWithSchema} | ||
| import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeSet, GenericRowWithSchema} |
There was a problem hiding this comment.
Do we need this addition in this PR? Otherwise, shall we avoid touching irrelevant files by reverting this change?
| } | ||
| } | ||
|
|
||
| test("DESCRIBE TABLE w/ char/varchar") { |
There was a problem hiding this comment.
Please add SPARK-33892: prefix.
| } | ||
| } | ||
|
|
||
| // TODO: Move this test to super after SPARK-33875 implements DESCRIBE COLUMN for v2 |
There was a problem hiding this comment.
Please make this as IDed TODO like TODO(SPARK-33875) and add some description about Move this test... to SPARK-33875's description.
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Please fix the linter error.
| super.afterAll() | ||
| } | ||
|
|
||
| test("SHOW CREATE TABLE AS SERDE w/ char/varchar") { |
|
Test build #133332 has finished for PR 30908 at commit
|
|
thanks, merging to master/3.1! |
### What changes were proposed in this pull request? Display char/varchar in - DESC table - DESC column - SHOW CREATE TABLE ### Why are the changes needed? show the correct definition for users ### Does this PR introduce _any_ user-facing change? yes, char/varchar column's will print char/varchar instead of string ### How was this patch tested? new tests Closes #30908 from yaooqinn/SPARK-33892. Authored-by: Kent Yao <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 29cca68) Signed-off-by: Wenchen Fan <[email protected]>
|
Test build #133347 has finished for PR 30908 at commit
|
5 participants
What changes were proposed in this pull request?
Display char/varchar in
Why are the changes needed?
show the correct definition for users
Does this PR introduce any user-facing change?
yes, char/varchar column's will print char/varchar instead of string
How was this patch tested?
new tests