[SPARK-33836][SS][PYTHON][FOLLOW-UP] Use test utils and clean up doctests in table and toTable #30873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #133169 has finished for PR 30873 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
Author
|
retest this please |
|
Test build #133177 has finished for PR 30873 at commit
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 21, 2020
… for each PySpark test job ### What changes were proposed in this pull request? This PR proposes to have its own metastore directory to avoid potential conflict in catalog operations. ### Why are the changes needed? To make PySpark tests less flaky. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested by trying some sleeps in #30873. Closes #30875 from HyukjinKwon/SPARK-33869. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 21, 2020
… for each PySpark test job ### What changes were proposed in this pull request? This PR proposes to have its own metastore directory to avoid potential conflict in catalog operations. ### Why are the changes needed? To make PySpark tests less flaky. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested by trying some sleeps in #30873. Closes #30875 from HyukjinKwon/SPARK-33869. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 38bbcca) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 21, 2020
… for each PySpark test job ### What changes were proposed in this pull request? This PR proposes to have its own metastore directory to avoid potential conflict in catalog operations. ### Why are the changes needed? To make PySpark tests less flaky. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? Manually tested by trying some sleeps in #30873. Closes #30875 from HyukjinKwon/SPARK-33869. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 38bbcca) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 21, 2020
… for each PySpark test job This PR proposes to have its own metastore directory to avoid potential conflict in catalog operations. To make PySpark tests less flaky. No, dev-only. Manually tested by trying some sleeps in #30873. Closes #30875 from HyukjinKwon/SPARK-33869. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 38bbcca) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
HeartSaVioR
approved these changes
Dec 21, 2020
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1 Thanks for the fix! Good cleanup indeed.
Contributor
|
Merging to master/branch-3.1. |
HeartSaVioR
pushed a commit
that referenced
this pull request
Dec 21, 2020
…ests in table and toTable ### What changes were proposed in this pull request? This PR proposes to: - Make doctests simpler to show the usage (since we're not running them now). - Use the test utils to drop the tables if exists. ### Why are the changes needed? Better docs and code readability. ### Does this PR introduce _any_ user-facing change? No, dev-only. It includes some doc changes in unreleased branches. ### How was this patch tested? Manually tested. ```bash cd python ./run-tests --python-executable=python3.9,python3.8 --testnames "pyspark.sql.tests.test_streaming StreamingTests" ``` Closes #30873 from HyukjinKwon/SPARK-33836. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]> (cherry picked from commit 4106731) Signed-off-by: Jungtaek Lim <[email protected]>
Member
Author
|
Thanks @HeartSaVioR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to:
Why are the changes needed?
Better docs and code readability.
Does this PR introduce any user-facing change?
No, dev-only. It includes some doc changes in unreleased branches.
How was this patch tested?
Manually tested.