Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Dec 10, 2020

What changes were proposed in this pull request?

This upgrades snappy-java to 1.1.8.2.

Why are the changes needed?

Minor version upgrade that includes:

  • Fixed an initialization issue when using a recent Mac OS X version
  • Support Apple Silicon (M1, Mac-aarch64)
  • Fixed the pure-java Snappy fallback logic when no native library for your platform is found.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending CIs)

@SparkQA
Copy link

SparkQA commented Dec 10, 2020

Test build #132525 has finished for PR 30698 at commit aad49d1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to branch-3.0.

HyukjinKwon pushed a commit that referenced this pull request Dec 10, 2020
### What changes were proposed in this pull request?

This upgrades snappy-java to 1.1.8.2.

### Why are the changes needed?

Minor version upgrade that includes:

- [Fixed](xerial/snappy-java#265) an initialization issue when using a recent Mac OS X version
- Support Apple Silicon (M1, Mac-aarch64)
- Fixed the pure-java Snappy fallback logic when no native library for your platform is found.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Unit test.

Closes #30698 from viirya/upgrade-snappy-3.0.

Authored-by: Liang-Chi Hsieh <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
@viirya viirya deleted the upgrade-snappy-3.0 branch December 27, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants