[SPARK-33709][SQL] Refactor FileTable #30670
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Dec 8, 2020
| } | ||
|
|
||
| lazy val dataSchema: StructType = { | ||
| StructType(fileSchema.filterNot(partitionSchema.contains)) |
Contributor
There was a problem hiding this comment.
should we consider caseSensitive option as line 106 ~ line 109:
val fields = fileSchema.fields.filterNot { field =>
val colName = PartitioningUtils.getColName(field, caseSensitive)
partitionNameSet.contains(colName)
}
Member
Author
There was a problem hiding this comment.
Yes. Let's see if there are other failures.
Contributor
There was a problem hiding this comment.
3 test in HiveThriftHttpServerSuite failed, seems these three use cases fail in other pr too ....
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #132421 has finished for PR 30670 at commit
|
LuciferYang
reviewed
Dec 9, 2020
| val isCaseSensitive = sqlConf.caseSensitiveAnalysis | ||
| val parquetSchema = | ||
| new SparkToParquetSchemaConverter(sparkSession.sessionState.conf).convert(schema) | ||
| new SparkToParquetSchemaConverter(sparkSession.sessionState.conf).convert(dataSchema) |
Contributor
There was a problem hiding this comment.
Maybe we should use readDataSchema() instead of dataSchema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?