Skip to content

Conversation

@huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

change

./build/sbt -Pdocker-integration-tests "testOnly *xxxIntegrationSuite" 

to

./build/sbt -Pdocker-integration-tests "testOnly org.apache.spark.sql.jdbc.xxxIntegrationSuite"

Why are the changes needed?

We only want to start v1 xxxIntegrationSuite, not the newly addedv2.xxxIntegrationSuite.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manually checked

@github-actions github-actions bot added the SQL label Nov 20, 2020
@dongjoon-hyun dongjoon-hyun changed the title [MINOR] Use absolute file name in docker integration test [MINOR][TESTS][DOCS] Use absolute file name in docker integration test Nov 20, 2020
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thanks, @huaxingao .
Merged to master for Apache Spark 3.1.0.

cc @maropu

@dongjoon-hyun dongjoon-hyun changed the title [MINOR][TESTS][DOCS] Use absolute file name in docker integration test [MINOR][TESTS][DOCS] Use fully-qualified class name in docker integration test Nov 20, 2020
@dongjoon-hyun
Copy link
Member

BTW, @huaxingao . I revised the PR title from absolute file name to fully-qualified class name.

@huaxingao
Copy link
Contributor Author

Thank you! @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Nov 20, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36039/

@SparkQA
Copy link

SparkQA commented Nov 20, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36039/

@SparkQA
Copy link

SparkQA commented Nov 20, 2020

Test build #131433 has finished for PR 30448 at commit 074aeb9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Nov 21, 2020

Thanks for the update, @huaxingao late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants