-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-32907][ML][PYTHON] Adaptively blockify instances - AFT,LiR,LoR #30355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-32907][ML][PYTHON] Adaptively blockify instances - AFT,LiR,LoR #30355
Conversation
rename param add comment
|
Test build #131000 has finished for PR 30355 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #131028 has finished for PR 30355 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document the default 0.0 behavior (set optimal block size, current 1MB) in the HasMaxBlockSizeInMB param doc.
otherwise LGTM.
|
Kubernetes integration test starting |
|
Test build #131252 has finished for PR 30355 at commit
|
|
Kubernetes integration test status failure |
|
Test build #131268 has finished for PR 30355 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
LGTM. |
|
Merge to master. |
|
@WeichenXu123 Thank you so much! |
What changes were proposed in this pull request?
use
maxBlockSizeInMBinstead ofblockSize(#rows) to control the stacking of vectors;Why are the changes needed?
the performance gain is mainly related to the nnz of block.
Does this PR introduce any user-facing change?
yes, param blockSize -> blockSizeInMB in master
How was this patch tested?
updated testsuites