Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

use maxBlockSizeInMB instead of blockSize (#rows) to control the stacking of vectors;

Why are the changes needed?

the performance gain is mainly related to the nnz of block.

Does this PR introduce any user-facing change?

yes, param blockSize -> blockSizeInMB in master

How was this patch tested?

updated testsuites

rename param

add comment
@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Test build #131000 has finished for PR 30355 at commit f8782a4.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35606/

@SparkQA
Copy link

SparkQA commented Nov 12, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35606/

@zhengruifeng zhengruifeng removed the CORE label Nov 13, 2020
@github-actions github-actions bot added the CORE label Nov 13, 2020
@SparkQA
Copy link

SparkQA commented Nov 13, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35634/

@SparkQA
Copy link

SparkQA commented Nov 13, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35634/

@SparkQA
Copy link

SparkQA commented Nov 13, 2020

Test build #131028 has finished for PR 30355 at commit 5f9e70f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon changed the title [SPARK-32907][ML][PYTHON] adaptively blockify instances - AFT,LiR,LoR [SPARK-32907][ML][PYTHON] Adaptively blockify instances - AFT,LiR,LoR Nov 13, 2020
Copy link
Contributor

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document the default 0.0 behavior (set optimal block size, current 1MB) in the HasMaxBlockSizeInMB param doc.
otherwise LGTM.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35855/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131252 has finished for PR 30355 at commit 48b2814.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35855/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Test build #131268 has finished for PR 30355 at commit 317bde9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35871/

@SparkQA
Copy link

SparkQA commented Nov 18, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35871/

@WeichenXu123
Copy link
Contributor

LGTM.

@WeichenXu123
Copy link
Contributor

Merge to master.

@zhengruifeng
Copy link
Contributor Author

@WeichenXu123 Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants