-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-23499][MESOS] Support for priority queues in Mesos scheduler #30352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
Outdated
Show resolved
Hide resolved
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
Outdated
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Outdated
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Outdated
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Show resolved
Hide resolved
...sos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
Outdated
Show resolved
Hide resolved
...sos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution at this module, @pgillet .
I finished my first round review and I left a few comments. Could you address those please?
|
Test build #131110 has finished for PR 30352 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #131114 has finished for PR 30352 at commit
|
|
Kubernetes integration test starting |
|
Test build #131116 has finished for PR 30352 at commit
|
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #131146 has finished for PR 30352 at commit
|
|
Kubernetes integration test starting |
|
Test build #131153 has finished for PR 30352 at commit
|
|
Kubernetes integration test status success |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #131172 has finished for PR 30352 at commit
|
|
Thank you so much for your updating, @pgillet . |
|
BTW, quick questions, @pgillet . Which Mesos versions are you using with Spark? |
Mesos 1.9.0 |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/DriverPage.scala
Outdated
Show resolved
Hide resolved
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala
Outdated
Show resolved
Hide resolved
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/ui/MesosClusterPage.scala
Outdated
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Outdated
Show resolved
Hide resolved
...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
Show resolved
Hide resolved
...sos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #131180 has finished for PR 30352 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you for your contribution, @pgillet .
Merged to master for Apache Spark 3.1.
|
You are added to the Apache Spark contributor group and SPARK-23499 is assigned to you. |
Awesome! Thank you for your time. |
What changes were proposed in this pull request?
I push this PR as I could not re-open the stale one #20665 .
As for Yarn or Kubernetes, Mesos users should be able to specify priority queues to define a workload management policy for queued drivers in the Mesos Cluster Dispatcher.
This would ensure scheduling order while enqueuing Spark applications for a Mesos cluster.
Why are the changes needed?
Currently, submitted drivers are kept in order of their submission: the first driver added to the queue will be the first one to be executed (FIFO), regardless of their priority.
See https://issues.apache.org/jira/projects/SPARK/issues/SPARK-23499 for more details.
Does this PR introduce any user-facing change?
The MesosClusterDispatcher UI shows now Spark jobs along with the queue to which they are submitted.
How was this patch tested?
Unit tests.
Also, this feature has been in production for 3 years now as we use a modified Spark 2.4.0 since then.