Skip to content

[SPARK-33205][BUILD] Bump snappy-java version to 1.1.8 #30120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-33205][BUILD] Bump snappy-java version to 1.1.8 #30120

wants to merge 1 commit into from

Conversation

@maropu
Copy link
Member

@maropu maropu commented Oct 21, 2020

What changes were proposed in this pull request?

This PR intends to upgrade snappy-java from 1.1.7.5 to 1.1.8.

Why are the changes needed?

For performance improvements; the released snappy-java bundles the latest Snappy v1.1.8 binaries with small performance improvements.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

GA tests.

@SparkQA
Copy link

SparkQA commented Oct 21, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34702/

@SparkQA
Copy link

SparkQA commented Oct 21, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34702/

srowen
srowen approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK pending tests

@SparkQA
Copy link

SparkQA commented Oct 21, 2020

Test build #130093 has finished for PR 30120 at commit 593e899.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@Fokko Fokko mentioned this pull request Oct 21, 2020
Merged
4 tasks
Fokko
Fokko approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's do the same for Parquet: apache/parquet-java#833

@viirya
Copy link
Member

viirya commented Oct 21, 2020

Thanks. Merging to master.

@viirya viirya closed this in 1b7367c Oct 21, 2020
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Oct 21, 2020

Great! Thank you all!

@maropu
Copy link
Member Author

maropu commented Oct 21, 2020

Thanks, all~

wangyum pushed a commit that referenced this pull request May 26, 2023
@turboFei
[CARMEL-6489][SPARK-33205][SPARK-33725][SPARK=35277][BUILD] Bump snap…
2d2f2b0 
…py-java version to 1.1.8.4 (#1198)

* [CARMEL-6489][SPARK-33205][BUILD] Bump snappy-java version to 1.1.8
Backport #30120

* [CARMEL-6489][SPARK-33725][BUILD] Upgrade snappy-java to 1.1.8.2
Backport #30690

* [CARMEL-6489][SPARK-35277][BUILD] Upgrade snappy to 1.1.8.4
Backport #32402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

@srowen srowen srowen approved these changes

@kiszk kiszk kiszk approved these changes

+1 more reviewer

@Fokko Fokko Fokko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.