[SPARK-4145] Web UI job pages #3009
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.ui.jobs | ||
|
|
||
| import scala.xml.{Node, NodeSeq} | ||
|
|
||
| import javax.servlet.http.HttpServletRequest | ||
|
|
||
| import org.apache.spark.JobExecutionStatus | ||
| import org.apache.spark.ui.{WebUIPage, UIUtils} | ||
| import org.apache.spark.ui.jobs.UIData.JobUIData | ||
|
|
||
| /** Page showing list of all ongoing and recently finished jobs */ | ||
| private[ui] class AllJobsPage(parent: JobsTab) extends WebUIPage("") { | ||
| private val startTime: Option[Long] = parent.sc.map(_.startTime) | ||
| private val listener = parent.listener | ||
|
|
||
| private def jobsTable(jobs: Seq[JobUIData]): Seq[Node] = { | ||
| val someJobHasJobGroup = jobs.exists(_.jobGroup.isDefined) | ||
|
|
||
| val columns: Seq[Node] = { | ||
| <th>{if (someJobHasJobGroup) "Job Id (Job Group)" else "Job Id"}</th> | ||
| <th>Description</th> | ||
| <th>Submitted</th> | ||
| <th>Duration</th> | ||
| <th class="sorttable_nosort">Stages: Succeeded/Total</th> | ||
| <th class="sorttable_nosort">Tasks (for all stages): Succeeded/Total</th> | ||
| } | ||
|
|
||
| def makeRow(job: JobUIData): Seq[Node] = { | ||
| val lastStageInfo = listener.stageIdToInfo.get(job.stageIds.max) | ||
| val lastStageData = lastStageInfo.flatMap { s => | ||
| listener.stageIdToData.get((s.stageId, s.attemptId)) | ||
| } | ||
|
Contributor
There was a problem hiding this comment. Can you move the code to compute the last stage's name up here? It was hard for me to figure out why you were grabbing the last stage here. |
||
| val isComplete = job.status == JobExecutionStatus.SUCCEEDED | ||
| val lastStageName = lastStageInfo.map(_.name).getOrElse("(Unknown Stage Name)") | ||
| val lastStageDescription = lastStageData.flatMap(_.description).getOrElse("") | ||
| val duration: Option[Long] = { | ||
| job.startTime.map { start => | ||
| val end = job.endTime.getOrElse(System.currentTimeMillis()) | ||
| end - start | ||
| } | ||
| } | ||
| val formattedDuration = duration.map(d => UIUtils.formatDuration(d)).getOrElse("Unknown") | ||
| val formattedSubmissionTime = job.startTime.map(UIUtils.formatDate).getOrElse("Unknown") | ||
|
Contributor
There was a problem hiding this comment. I realize we use in
Contributor
Author
There was a problem hiding this comment. In other places, we have "Unknown stage name", etc; I'm not sure that this is a huge win (it would be beneficial if we decided to localize, though, but we're not doing that here). |
||
| val detailUrl = | ||
| "%s/jobs/job?id=%s".format(UIUtils.prependBaseUri(parent.basePath), job.jobId) | ||
| <tr> | ||
| <td sorttable_customkey={job.jobId.toString}> | ||
| {job.jobId} {job.jobGroup.map(id => s"($id)").getOrElse("")} | ||
| </td> | ||
| <td> | ||
| <div><em>{lastStageDescription}</em></div> | ||
| <a href={detailUrl}>{lastStageName}</a> | ||
| </td> | ||
| <td sorttable_customkey={job.startTime.getOrElse(-1).toString}> | ||
| {formattedSubmissionTime} | ||
| </td> | ||
| <td sorttable_customkey={duration.getOrElse(-1).toString}>{formattedDuration}</td> | ||
| <td class="stage-progress-cell"> | ||
| {job.completedStageIndices.size}/{job.stageIds.size - job.numSkippedStages} | ||
| {if (job.numFailedStages > 0) s"(${job.numFailedStages} failed)"} | ||
| {if (job.numSkippedStages > 0) s"(${job.numSkippedStages} skipped)"} | ||
| </td> | ||
| <td class="progress-cell"> | ||
| {UIUtils.makeProgressBar(started = job.numActiveTasks, completed = job.numCompletedTasks, | ||
| failed = job.numFailedTasks, skipped = job.numSkippedTasks, | ||
| total = job.numTasks - job.numSkippedTasks)} | ||
| </td> | ||
| </tr> | ||
| } | ||
|
|
||
| <table class="table table-bordered table-striped table-condensed sortable"> | ||
| <thead>{columns}</thead> | ||
| <tbody> | ||
| {jobs.map(makeRow)} | ||
| </tbody> | ||
| </table> | ||
| } | ||
|
|
||
| def render(request: HttpServletRequest): Seq[Node] = { | ||
| listener.synchronized { | ||
| val activeJobs = listener.activeJobs.values.toSeq | ||
| val completedJobs = listener.completedJobs.reverse.toSeq | ||
| val failedJobs = listener.failedJobs.reverse.toSeq | ||
| val now = System.currentTimeMillis | ||
|
|
||
| val activeJobsTable = | ||
| jobsTable(activeJobs.sortBy(_.startTime.getOrElse(-1L)).reverse) | ||
| val completedJobsTable = | ||
| jobsTable(completedJobs.sortBy(_.endTime.getOrElse(-1L)).reverse) | ||
| val failedJobsTable = | ||
| jobsTable(failedJobs.sortBy(_.endTime.getOrElse(-1L)).reverse) | ||
|
|
||
| val summary: NodeSeq = | ||
| <div> | ||
| <ul class="unstyled"> | ||
| {if (startTime.isDefined) { | ||
| // Total duration is not meaningful unless the UI is live | ||
| <li> | ||
| <strong>Total Duration: </strong> | ||
| {UIUtils.formatDuration(now - startTime.get)} | ||
| </li> | ||
| }} | ||
| <li> | ||
| <strong>Scheduling Mode: </strong> | ||
| {listener.schedulingMode.map(_.toString).getOrElse("Unknown")} | ||
| </li> | ||
| <li> | ||
| <a href="#active"><strong>Active Jobs:</strong></a> | ||
| {activeJobs.size} | ||
| </li> | ||
| <li> | ||
| <a href="#completed"><strong>Completed Jobs:</strong></a> | ||
| {completedJobs.size} | ||
| </li> | ||
| <li> | ||
| <a href="#failed"><strong>Failed Jobs:</strong></a> | ||
| {failedJobs.size} | ||
| </li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| val content = summary ++ | ||
| <h4 id="active">Active Jobs ({activeJobs.size})</h4> ++ activeJobsTable ++ | ||
| <h4 id="completed">Completed Jobs ({completedJobs.size})</h4> ++ completedJobsTable ++ | ||
| <h4 id ="failed">Failed Jobs ({failedJobs.size})</h4> ++ failedJobsTable | ||
|
|
||
| val helpText = """A job is triggered by a action, like "count()" or "saveAsTextFile()".""" + | ||
|
Contributor
There was a problem hiding this comment. minor: why not just escape the
Contributor
Author
There was a problem hiding this comment. I don't care either way; do you have a strong opinion on this or can I just leave it as is? |
||
| " Click on a job's title to see information about the stages of tasks associated with" + | ||
| " the job." | ||
|
|
||
| UIUtils.headerSparkPage("Spark Jobs", content, parent, helpText = Some(helpText)) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I moved this here to avoid a race-condition where a user could browse to the web UI before this field was initialized. There didn't seem to be any particular reason for it to be here as opposed to anywhere else.