[SPARK-32907][ML] adaptively blockify instances - revert blockify gmm #29782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #128806 has finished for PR 29782 at commit
|
|
Test build #128807 has finished for PR 29782 at commit
|
HyukjinKwon
reviewed
Sep 18, 2020
| return self._set(aggregationDepth=value) | ||
|
|
||
| @since("3.1.0") | ||
| def setBlockSize(self, value): |
srowen
reviewed
Sep 21, 2020
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems OK if this is just reverting something that went into 3.1.
Member
|
Feel free to merge |
Contributor
|
Jenkins retest this |
Contributor
|
Do we need to revert the change https://github.com/apache/spark/pull/27473/files#r493100573 and https://github.com/apache/spark/pull/27473/files#r493100907 |
Contributor
Author
|
@WeichenXu123 Good catch! Thanks |
|
Test build #129002 has finished for PR 29782 at commit
|
WeichenXu123
approved these changes
Sep 23, 2020
Contributor
Author
|
Merged to master. Thanks all for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
revert blockify gmm
Why are the changes needed?
@WeichenXu123 and I thought we should use memory size instead of number of rows to blockify instance; then if a buffer's size is large and determined by number of rows, we should discard it.
In GMM, we found that the pre-allocated memory maybe too large and should be discarded:
We had some offline discuss and thought it is better to revert blockify GMM.
Does this PR introduce any user-facing change?
blockSize added in master branch will be removed
How was this patch tested?
existing testsuites