Skip to content

[SPARK-1442] [SQL] window function implement #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[SPARK-1442] [SQL] window function implement #2953

wants to merge 11 commits into from

Conversation

@guowei2
Copy link
Contributor

@guowei2 guowei2 commented Oct 27, 2014

aims of step1 ( this pr):

  1. support parse sql with complex window define
  2. support most of aggregate-functions with window-spec
  3. support window range

aims of step2:
support the rest of un-support features as below:

  1. not support with multi-different window partitions ,but support with multi-same window partitions
  2. not support with both window partition and group by
  3. not support lead, lag (default lead and lag function lookup in HiveFunctionRegistry are GenericUDF, we need GenericUDAF)
  4. not support rank, dense_rank
  5. not support sql parse with TOK_PTBLFUNCTION

https://issues.apache.org/jira/browse/HIVE-4197
https://issues.apache.org/jira/browse/HIVE-896

@guowei2 guowei2 changed the title Spark 1442 step 1 [SPARK-1442] [SQL] window function implement Oct 27, 2014
@AmplabJenkins
Copy link

AmplabJenkins commented Oct 27, 2014

Can one of the admins verify this patch?

@rxin
Copy link
Contributor

rxin commented Oct 28, 2014

Can you write a short high level design doc for this change and attach it to JIRA?

wangxiaojing
wangxiaojing reviewed Oct 29, 2014
View reviewed changes
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala Outdated
Copy link
Contributor

@wangxiaojing wangxiaojing Oct 29, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after //

@liancheng liancheng mentioned this pull request Dec 15, 2014
Closed
@guowei2 guowei2 closed this Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guowei2 @AmplabJenkins @rxin @wangxiaojing