-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-32646][SQL][3.0][test-hadoop2.7][test-hive1.2] ORC predicate pushdown should work with case-insensitive analysis #29513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #127770 has finished for PR 29513 at commit
|
|
retest this please |
This comment has been minimized.
This comment has been minimized.
|
retest this please |
|
Test build #127780 has finished for PR 29513 at commit
|
|
retest this please |
|
Test build #127785 has finished for PR 29513 at commit
|
|
Not sure if these errors are related. E.g., for ORC unrelated and no pushdown predicate. Btw, I cannot reproduce the errors locally. |
|
Err.. I think these tests are already failed in current branch-3.0 and master branches. Please see #29517. I created SPARK-32689 to track it. |
|
retest this please |
|
Test build #127828 has finished for PR 29513 at commit
|
|
retest this please |
|
Test build #127832 has finished for PR 29513 at commit
|
…ushdown should work with case-insensitive analysis ### What changes were proposed in this pull request? This PR proposes to fix ORC predicate pushdown under case-insensitive analysis case. The field names in pushed down predicates don't need to match in exact letter case with physical field names in ORC files, if we enable case-insensitive analysis. ### Why are the changes needed? Currently ORC predicate pushdown doesn't work with case-insensitive analysis. A predicate "a < 0" cannot pushdown to ORC file with field name "A" under case-insensitive analysis. But Parquet predicate pushdown works with this case. We should make ORC predicate pushdown work with case-insensitive analysis too. ### Does this PR introduce _any_ user-facing change? Yes, after this PR, under case-insensitive analysis, ORC predicate pushdown will work. ### How was this patch tested? Unit tests. Closes #29513 from viirya/fix-orc-pushdown-3.0. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
|
thanks, merging to 3.0! |
|
Thanks! @cloud-fan |
What changes were proposed in this pull request?
This PR proposes to fix ORC predicate pushdown under case-insensitive analysis case. The field names in pushed down predicates don't need to match in exact letter case with physical field names in ORC files, if we enable case-insensitive analysis.
Why are the changes needed?
Currently ORC predicate pushdown doesn't work with case-insensitive analysis. A predicate "a < 0" cannot pushdown to ORC file with field name "A" under case-insensitive analysis.
But Parquet predicate pushdown works with this case. We should make ORC predicate pushdown work with case-insensitive analysis too.
Does this PR introduce any user-facing change?
Yes, after this PR, under case-insensitive analysis, ORC predicate pushdown will work.
How was this patch tested?
Unit tests.