[SPARK-32528][SQL][TEST][3.0] The analyze method should make sure the plan is analyzed #29400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is analyzed This PR updates the `analyze` method to make sure the plan can be resolved. It also fixes some miswritten optimizer tests. It's error-prone if the `analyze` method can return an unresolved plan. no test only Closes apache#29349 from cloud-fan/test. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
Member
|
Got it. Thank you for this backporting, @cloud-fan . |
dongjoon-hyun
approved these changes
Aug 10, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending Jenkins)
|
Test build #127291 has finished for PR 29400 at commit
|
Member
|
Merged to branch-3.0. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 10, 2020
… plan is analyzed ### What changes were proposed in this pull request? backport #29349 to 3.0. This PR updates the `analyze` method to make sure the plan can be resolved. It also fixes some miswritten optimizer tests. ### Why are the changes needed? It's error-prone if the `analyze` method can return an unresolved plan. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? test only Closes #29400 from cloud-fan/backport. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Thank you so much, @cloud-fan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backport #29349 to 3.0.
This PR updates the
analyzemethod to make sure the plan can be resolved. It also fixes some miswritten optimizer tests.Why are the changes needed?
It's error-prone if the
analyzemethod can return an unresolved plan.Does this PR introduce any user-facing change?
no
How was this patch tested?
test only