[SPARK-32575][CORE][TESTS] Bump up timeouts in BlockManagerDecommissionIntegrationSuite to reduce flakyness #29388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #127220 has finished for PR 29388 at commit
|
Member
|
Please fill out the description |
Author
|
Thanks @srowen. cc: @HyukjinKwon and @holdenk ... this PR is ready for review but first it would be great if someone could whitelist it to run on jenkins. |
agrawaldevesh
changed the title
Contributor
|
Jenkins add to white list |
Contributor
|
Jenkins ok to test |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @agrawaldevesh .
Since you are one of the active contributor, it would be great if you file a JIRA and use it in the PR title. :)
- https://spark.apache.org/contributing.html (Section 'Pull Request').
agrawaldevesh
changed the title
|
Test build #127245 has finished for PR 29388 at commit
|
Member
|
I observed the failure here, too. |
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Aug 10, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @agrawaldevesh .
Merged to master.
Contributor
|
Thanks for taking care of this :) |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Oct 27, 2020
…onIntegrationSuite to reduce flakyness ### What changes were proposed in this pull request? As reported by HyukjinKwon, BlockManagerDecommissionIntegrationSuite test is apparently still flaky (even after apache#29226): apache#29226 (comment). The new flakyness is because the executors are not launching in the 6 seconds time out I had given them when run under github checks. Bumped up the timeouts. ### Why are the changes needed? To make this test not flaky so that it can give us high signal if decommissioning regresses. ### Does this PR introduce _any_ user-facing change? No, unit test only check. ### How was this patch tested? No new tests. Just github and jenkins. Closes apache#29388 from agrawaldevesh/more_bm_harden. Authored-by: Devesh Agrawal <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As reported by @HyukjinKwon, BlockManagerDecommissionIntegrationSuite test is apparently still flaky (even after #29226): #29226 (comment).
The new flakyness is because the executors are not launching in the 6 seconds time out I had given them when run under github checks.
Bumped up the timeouts.
Why are the changes needed?
To make this test not flaky so that it can give us high signal if decommissioning regresses.
Does this PR introduce any user-facing change?
No, unit test only check.
How was this patch tested?
No new tests. Just github and jenkins.