[WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre #29325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hadoop 3.2.0 still uses older Guava 11.0.2. I'm not sure if we can just upgrade Guava without touching Hadoop dependency. I want to run the patch through jenkins (sbt and maven) to see how well it works out. #29326 upgrades Guava and Hadoop together. |
|
Test build #126932 has finished for PR 29325 at commit
|
Member
|
retest this please |
|
Test build #126936 has finished for PR 29325 at commit
|
Member
|
hm, it looks a valid failure. |
Member
|
Is this duplicated by #29326 ? |
Member
|
I left a comment here. |
Member
|
I'd like to recommend to close the PR while keeping JIRA is open. you can reopen this PR when it's ready. |
Member
Author
|
Thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades Guava to newer 27.0-jre.
Why are the changes needed?
Guava 14.0.1 is pretty old and is among the affected Guava versions of CVE-2018-10237.
All newer Hadoop releases are going to be built with a later guava version, e.g. 27.0-jre, including Hadoop 3.1.3, 3.2.1, 3.3.0.
This PR leaves Hadoop version untouched.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins tests.