-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-32230][R][INFRA] Use Hadoop 2.7 profile in AppVeyor SparkR build #29040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @dongjoon-hyun. BTW, I will use Hadoop 3 profile in AppVeyor later in a separate PR. |
|
I filed a JIRA for that at SPARK-32231 |
|
Oh. Thanks. |
| # See SPARK-28759. | ||
| # Ideally we should check the tests related to Hive in SparkR as well (SPARK-31745). | ||
| - cmd: mvn -DskipTests -Psparkr -Djna.nosys=true package | ||
| - cmd: mvn -DskipTests -Phadoop-2.7 -Psparkr -Djna.nosys=true package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we upgrade to @steveloughran 's Hadoop 3.0 instead of using Hadoop 2.7.1 here?
# ========================== Hadoop bin package
# This must match the version at https://github.com/steveloughran/winutils/tree/master/hadoop-2.7.1
$hadoopVer = "2.7.1"
He already provides Hadoop 3 also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sure. Let me try!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a separate PR for that #29042. If that passes the tests, we can merge that one and close this.
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we can move forward, @HyukjinKwon .
Also, cc @steveloughran . How do you think about Hadoop 3 on Windows?
|
Test build #125362 has finished for PR 29040 at commit
|
What changes were proposed in this pull request?
https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/33976604
AppVeyor build seems broken after we change the default Hadoop version from 2 to 3.
This PR moves back to Hadoop 2 for now.
Why are the changes needed?
To recover the build in AppVeyor.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
AppVeyor build will test it out.