Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/33976604

AppVeyor build seems broken after we change the default Hadoop version from 2 to 3.
This PR moves back to Hadoop 2 for now.

Why are the changes needed?

To recover the build in AppVeyor.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

AppVeyor build will test it out.

@HyukjinKwon HyukjinKwon changed the title [WIP] Use Hadoop 2.7 profile in AppVeyor SparkR build [SPARK-32230][R][INFRA] Use Hadoop 2.7 profile in AppVeyor SparkR build Jul 8, 2020
@HyukjinKwon
Copy link
Member Author

cc @dongjoon-hyun.

BTW, I will use Hadoop 3 profile in AppVeyor later in a separate PR.

@HyukjinKwon
Copy link
Member Author

I filed a JIRA for that at SPARK-32231

@dongjoon-hyun
Copy link
Member

Oh. Thanks.

# See SPARK-28759.
# Ideally we should check the tests related to Hive in SparkR as well (SPARK-31745).
- cmd: mvn -DskipTests -Psparkr -Djna.nosys=true package
- cmd: mvn -DskipTests -Phadoop-2.7 -Psparkr -Djna.nosys=true package
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade to @steveloughran 's Hadoop 3.0 instead of using Hadoop 2.7.1 here?

# ========================== Hadoop bin package
# This must match the version at https://github.com/steveloughran/winutils/tree/master/hadoop-2.7.1
$hadoopVer = "2.7.1"

He already provides Hadoop 3 also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sure. Let me try!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a separate PR for that #29042. If that passes the tests, we can merge that one and close this.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we can move forward, @HyukjinKwon .

Also, cc @steveloughran . How do you think about Hadoop 3 on Windows?

@SparkQA
Copy link

SparkQA commented Jul 8, 2020

Test build #125362 has finished for PR 29040 at commit b4d1c6c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon closed this Jul 9, 2020
@HyukjinKwon HyukjinKwon deleted the test-appveyor branch July 27, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants