Skip to content

[SPARK-32200][WEBUI] Redirect to the history page when accessed to /history on the HistoryServer without appliation id #29016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-32200][WEBUI] Redirect to the history page when accessed to /history on the HistoryServer without appliation id #29016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ class HistoryServer(
// attempt ID (separated by a slash).
val parts = Option(req.getPathInfo()).getOrElse("").split("/")
if (parts.length < 2) {
res.sendError(HttpServletResponse.SC_BAD_REQUEST,
s"Unexpected path info in request (URI = ${req.getRequestURI()}")
return
res.sendRedirect("/")
}

val appId = parts(1)
Expand Down
13 changes: 13 additions & 0 deletions core/src/test/scala/org/apache/spark/deploy/history/HistoryServerSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,19 @@ class HistoryServerSuite extends SparkFunSuite with BeforeAndAfter with Matchers
val actualContentType = conn.getContentType
assert(actualContentType === expectedContentType)
}

test("Redirect to the root page when accessed to /history/") {
val port = server.boundPort
val url = new URL(s"http://localhost:$port/history/")
val conn = url.openConnection().asInstanceOf[HttpURLConnection]
conn.setRequestMethod("GET")
conn.setUseCaches(false)
conn.setDefaultUseCaches(false)
conn.setInstanceFollowRedirects(false)
conn.connect()
assert(conn.getResponseCode === 302)
assert(conn.getHeaderField("Location") === s"http://localhost:$port/")
}
}

object HistoryServerSuite {
Expand Down