-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-32178][TESTS] Disable test-dependencies.sh from Jenkins jobs #29004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you review this please, @HyukjinKwon and @maropu ? |
|
@dongjoon-hyun, could we maybe test this it in amp-jenkins-worker-04? I was doubting if other builds pass fine given that it has sort of broken .m2 cache. For some reasons #28957 consistently uses amp-jenkins-worker-04. Let me try to port it there and see if tests pass. |
|
How can we specify the worker? Maybe, by triggering multiple times until we reach
|
|
I don't know .. maybe that's the only way .. |
|
BTW, another purpose of this PR is off-loading AmpLab Jenkins jobs. We will save more resources there and reduce the test time by taking advantage the existing GitHub test coverage. |
|
Retest this please. |
|
Retest this please |
6 similar comments
|
Retest this please |
|
Retest this please |
|
Retest this please |
|
Retest this please |
|
Retest this please |
|
Retest this please |
|
#29004 (comment) got started in worker 4! |
|
Wow. We are lucky! :) |
|
Okay, let me just merge this one. At least the build got started properly, and Github Actions will test the dependencies properly. |
|
Merged to master. |
|
Thank you for review and merge. |
|
Nice update, thanks, @dongjoon-hyun ! |
|
Thank you, @maropu ! |
|
Test build #125005 has finished for PR 29004 at commit
|
|
Test build #125001 has finished for PR 29004 at commit
|
|
Would we want to offload gendoc as well? Similar situation occurs for gendoc in worker-05 and Github Action passed. |
|
Oh, let me try. Thank you for reporting, @HeartSaVioR . |
|
Hmm. It seems that we need another GitHub Action jobs for that because the current In @HeartSaVioR 's PR, it was the following. I guess it depends on the PRBuilder configuration at each time. |
|
Let me summarize this issue in a WIP PR~ We can offload it if that is not used in the release process. |
|
Or, we can add a test coverage for this. |
Ah OK that might be tricky. It'd be great if we can imitate the same behavior. |
|
Ya. Let's continue the discuss on #29017 |
What changes were proposed in this pull request?
This PR aims to disable dependency tests(test-dependencies.sh) from Jenkins.
Why are the changes needed?
test-dependencies.shfails very frequently in AmpLab Jenkins environment. For example, in the following irrelevant PR, it fails 5 times during 6 hours.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins without
test-dependencies.shinvocation.