Skip to content

[SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate #28999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-32209][SQL] Re-use GetTimestamp in ParseToDate #28999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...talyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,8 +1450,7 @@ case class ParseToDate(left: Expression, format: Option[Expression], child: Expr
extends RuntimeReplaceable {

def this(left: Expression, format: Expression) {
this(left, Option(format),
Cast(SecondsToTimestamp(UnixTimestamp(left, format)), DateType))
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @MaxGekk . If you don't mind, please make a JIRA issue for this. That will give us a traceability for this.

Copy link
Member

@HyukjinKwon HyukjinKwon Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking about it too. Maybe it's best to file a JIRA

Copy link
Member Author

@MaxGekk MaxGekk Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

this(left, Option(format), Cast(GetTimestamp(left, format), DateType))
}

def this(left: Expression) = {
Expand Down