[SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window #28987

BryanCutler · 2020-07-03T02:08:52Z

What changes were proposed in this pull request?

Improve the error message in test GroupedMapInPandasTests.test_grouped_over_window_with_key to show the incorrect values.

Why are the changes needed?

This test failure has come up often in Arrow testing because it tests a struct with timestamp values through a Pandas UDF. The current error message is not helpful as it doesn't show the incorrect values, only that it failed. This change will instead raise an assertion error with the incorrect values on a failure.

Before:

======================================================================
FAIL: test_grouped_over_window_with_key (pyspark.sql.tests.test_pandas_grouped_map.GroupedMapInPandasTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/spark/python/pyspark/sql/tests/test_pandas_grouped_map.py", line 588, in test_grouped_over_window_with_key
    self.assertTrue(all([r[0] for r in result]))
AssertionError: False is not true

After:

======================================================================
ERROR: test_grouped_over_window_with_key (pyspark.sql.tests.test_pandas_grouped_map.GroupedMapInPandasTests)
----------------------------------------------------------------------
...
AssertionError: {'start': datetime.datetime(2018, 3, 20, 0, 0), 'end': datetime.datetime(2018, 3, 25, 0, 0)}, != {'start': datetime.datetime(2020, 3, 20, 0, 0), 'end': datetime.datetime(2020, 3, 25, 0, 0)}

Does this PR introduce any user-facing change?

No

How was this patch tested?

Improved existing test

…indow_with_key

BryanCutler · 2020-07-03T02:09:23Z

This is currently being looked at in apache/arrow#7604

python/pyspark/sql/tests/test_pandas_grouped_map.py

BryanCutler · 2020-07-03T05:13:07Z

ping @HyukjinKwon please take a look, thanks!

HyukjinKwon

LGTM

SparkQA · 2020-07-05T20:44:43Z

Test build #124929 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T01:13:31Z

retest this please

SparkQA · 2020-07-06T02:06:57Z

Test build #124992 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T02:14:46Z

retest this please

SparkQA · 2020-07-06T02:46:12Z

Test build #125000 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T03:05:14Z

retest this please

SparkQA · 2020-07-06T03:51:31Z

Test build #125011 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T03:57:32Z

retest this please

SparkQA · 2020-07-06T04:44:09Z

Test build #125020 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

BryanCutler · 2020-07-06T05:00:41Z

retest this please

SparkQA · 2020-07-06T05:43:09Z

Test build #125028 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T06:00:25Z

I think .. the machines became very slow .. for some reasons.

HyukjinKwon · 2020-07-06T06:00:31Z

retest this please

SparkQA · 2020-07-06T06:45:08Z

Test build #125031 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T08:24:36Z

retest this please

SparkQA · 2020-07-06T08:59:33Z

Test build #125050 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T10:19:01Z

retest this please

SparkQA · 2020-07-06T10:51:51Z

Test build #125061 has finished for PR 28987 at commit 70da8b5.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T11:06:56Z

retest this please

SparkQA · 2020-07-06T11:58:48Z

Test build #125068 has finished for PR 28987 at commit 70da8b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2020-07-06T12:38:59Z

Woah, finally

HyukjinKwon · 2020-07-06T12:39:24Z

Merged to master and branch-3.0.

…map test with window ### What changes were proposed in this pull request? Improve the error message in test GroupedMapInPandasTests.test_grouped_over_window_with_key to show the incorrect values. ### Why are the changes needed? This test failure has come up often in Arrow testing because it tests a struct with timestamp values through a Pandas UDF. The current error message is not helpful as it doesn't show the incorrect values, only that it failed. This change will instead raise an assertion error with the incorrect values on a failure. Before: ``` ====================================================================== FAIL: test_grouped_over_window_with_key (pyspark.sql.tests.test_pandas_grouped_map.GroupedMapInPandasTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/spark/python/pyspark/sql/tests/test_pandas_grouped_map.py", line 588, in test_grouped_over_window_with_key self.assertTrue(all([r[0] for r in result])) AssertionError: False is not true ``` After: ``` ====================================================================== ERROR: test_grouped_over_window_with_key (pyspark.sql.tests.test_pandas_grouped_map.GroupedMapInPandasTests) ---------------------------------------------------------------------- ... AssertionError: {'start': datetime.datetime(2018, 3, 20, 0, 0), 'end': datetime.datetime(2018, 3, 25, 0, 0)}, != {'start': datetime.datetime(2020, 3, 20, 0, 0), 'end': datetime.datetime(2020, 3, 25, 0, 0)} ``` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Improved existing test Closes #28987 from BryanCutler/pandas-grouped-map-test-output-SPARK-32162. Authored-by: Bryan Cutler <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>

BryanCutler · 2020-07-06T20:57:19Z

Wow, Jenkins must have been slow back to work after the long weekend.. Thanks for the help @HyukjinKwon !

Improved error message of GroupedMapInPandasTests.test_grouped_over_w…

8dda6c6

…indow_with_key

probot-autolabeler bot added PYTHON SQL labels Jul 3, 2020

Fix typo

43a8cf6

BryanCutler commented Jul 3, 2020

View reviewed changes

python/pyspark/sql/tests/test_pandas_grouped_map.py Outdated Show resolved Hide resolved

Needed to properly check result with group num

70da8b5

HyukjinKwon approved these changes Jul 3, 2020

View reviewed changes

HyukjinKwon closed this in 1d18096 Jul 6, 2020

BryanCutler deleted the pandas-grouped-map-test-output-SPARK-32162 branch July 6, 2020 20:57

[SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window #28987

[SPARK-32162][PYTHON][TESTS] Improve error message of Pandas grouped map test with window #28987

Uh oh!

Conversation

BryanCutler commented Jul 3, 2020

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

BryanCutler commented Jul 3, 2020

Uh oh!

Uh oh!

BryanCutler commented Jul 3, 2020

Uh oh!

HyukjinKwon left a comment

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Jul 5, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

BryanCutler commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

SparkQA commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

HyukjinKwon commented Jul 6, 2020

Uh oh!

BryanCutler commented Jul 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants