-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-23631][ML][PySpark] Add summary to RandomForestClassificationModel #28913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| predictionColName, | ||
| $(labelCol), | ||
| weightColName, | ||
| Array(0.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for non iterative algorithm, set objectiveHistory to Array(0.0).
|
Test build #124434 has finished for PR 28913 at commit
|
|
Test build #124578 has finished for PR 28913 at commit
|
|
Test build #124580 has finished for PR 28913 at commit
|
|
It seems that you need to add summary in ml one by one. |
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@zhengruifeng |
|
Merged to master |
|
Thanks! @srowen @zhengruifeng |
What changes were proposed in this pull request?
Add summary to RandomForestClassificationModel...
Why are the changes needed?
so user can get a summary of this classification model, and retrieve common metrics such as accuracy, weightedTruePositiveRate, roc (for binary), pr curves (for binary), etc.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Add new tests