[SPARK-31997][SQL][TESTS] Drop test_udtf table when SingleSessionSuite test completed #28838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @xuanyuanking |
Member
|
ok to test. |
|
Test build #124101 has finished for PR 28838 at commit
|
Contributor
Author
|
retest this please |
1 similar comment
Member
|
retest this please |
|
Test build #124112 has finished for PR 28838 at commit
|
wangyum
approved these changes
Jun 16, 2020
HyukjinKwon
approved these changes
Jun 16, 2020
Member
|
Merged to master, branch-3.0 and branch-2.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 16, 2020
…e test completed ### What changes were proposed in this pull request? `SingleSessionSuite` not do `DROP TABLE IF EXISTS test_udtf` when test completed, then if we do mvn test `HiveThriftBinaryServerSuite`, the test case named `SPARK-11595 ADD JAR with input path having URL scheme` will FAILED because it want to re-create an exists table test_udtf. ### Why are the changes needed? test suite shouldn't rely on their execution order ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Manual test，mvn test SingleSessionSuite and HiveThriftBinaryServerSuite in order Closes #28838 from LuciferYang/drop-test-table. Authored-by: yangjie01 <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit d24d27f) Signed-off-by: HyukjinKwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 16, 2020
…e test completed ### What changes were proposed in this pull request? `SingleSessionSuite` not do `DROP TABLE IF EXISTS test_udtf` when test completed, then if we do mvn test `HiveThriftBinaryServerSuite`, the test case named `SPARK-11595 ADD JAR with input path having URL scheme` will FAILED because it want to re-create an exists table test_udtf. ### Why are the changes needed? test suite shouldn't rely on their execution order ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Manual test，mvn test SingleSessionSuite and HiveThriftBinaryServerSuite in order Closes #28838 from LuciferYang/drop-test-table. Authored-by: yangjie01 <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit d24d27f) Signed-off-by: HyukjinKwon <[email protected]>
Contributor
Author
Member
|
+1, late LGTM. Thanks. |
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jun 25, 2020
…e test completed ### What changes were proposed in this pull request? `SingleSessionSuite` not do `DROP TABLE IF EXISTS test_udtf` when test completed, then if we do mvn test `HiveThriftBinaryServerSuite`, the test case named `SPARK-11595 ADD JAR with input path having URL scheme` will FAILED because it want to re-create an exists table test_udtf. ### Why are the changes needed? test suite shouldn't rely on their execution order ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Manual test，mvn test SingleSessionSuite and HiveThriftBinaryServerSuite in order Closes apache#28838 from LuciferYang/drop-test-table. Authored-by: yangjie01 <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit d24d27f) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SingleSessionSuitenot doDROP TABLE IF EXISTS test_udtfwhen test completed, then if we do mvn testHiveThriftBinaryServerSuite, the test case namedSPARK-11595 ADD JAR with input path having URL schemewill FAILED because it want to re-create an exists table test_udtf.Why are the changes needed?
test suite shouldn't rely on their execution order
Does this PR introduce any user-facing change?
no
How was this patch tested?
Manual test，mvn test SingleSessionSuite and HiveThriftBinaryServerSuite in order