[SPARK-31959][SQL][TESTS][FOLLOWUP] Adopt the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" to outdated tzdb #28832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@HyukjinKwon @cloud-fan @dongjoon-hyun Please, review this PR. |
|
Test build #124047 has finished for PR 28832 at commit
|
Member
Author
|
The issue #28832 (comment) is fixed by #28816 |
Member
Author
|
jenkins, retest this, please |
cloud-fan
approved these changes
Jun 15, 2020
|
Test build #124052 has finished for PR 28832 at commit
|
Member
|
Thank you, @MaxGekk and @cloud-fan . |
dongjoon-hyun
approved these changes
Jun 15, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
MaxGekk
added a commit
to MaxGekk/spark
that referenced
this pull request
Jun 15, 2020
…-> HKT at Asia/Hong_Kong in 1945" to outdated tzdb Old JDK can have outdated time zone database in which `Asia/Hong_Kong` doesn't have timestamp overlapping in 1946 at all. This PR changes the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" in `RebaseDateTimeSuite`, and makes it tolerant to the case. To fix the test failures on old JDK w/ outdated tzdb like on Jenkins machine `research-jenkins-worker-09`. No By running the test on old JDK Closes apache#28832 from MaxGekk/HongKong-tz-1945-followup. Authored-by: Max Gekk <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit eae1747) Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Old JDK can have outdated time zone database in which
Asia/Hong_Kongdoesn't have timestamp overlapping in 1945 at all. This PR changes the test "SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945" inRebaseDateTimeSuite, and makes it tolerant to the case.Why are the changes needed?
To fix the test failures on old JDK w/ outdated tzdb like on Jenkins machine
research-jenkins-worker-09.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the test on old JDK