[SPARK-30119][WEBUI]Support pagination for streaming tab #28748
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? * Pagination Support is added to all tables of streaming page in spark web UI. For adding pagination support, existing classes from apache#7399 were used. * Earlier streaming page has two tables `Active Batches` and `Completed Batches`. Now, we will have three tables `Running Batches`, `Waiting Batches` and `Completed Batches`. If we have large number of waiting and running batches then keeping track in a single table is difficult. Also other pages have different table for different type type of data. * Earlier empty tables were shown. Now only non-empty tables will be shown. `Active Batches` table used to show details of waiting batches followed by running batches. ### Why are the changes needed? Pagination will allow users to analyse the table in much better way. All spark web UI pages support pagination apart from streaming pages, so this will add consistency as well. Also it might fix the potential OOM errors that can arise. ### Does this PR introduce _any_ user-facing change? Yes. `Active Batches` table is split into two tables `Running Batches` and `Waiting Batches`. Pagination Support is added to the all the tables. Every other functionality is unchanged. ### How was this patch tested? Manually. Before changes: <img width="1667" alt="Screenshot 2020-05-03 at 7 07 14 PM" src="https://user-images.githubusercontent.com/15366835/80915680-8fb44b80-8d71-11ea-9957-c4a3769b8b67.png"> After Changes: <img width="1669" alt="Screenshot 2020-05-03 at 6 51 22 PM" src="https://user-images.githubusercontent.com/15366835/80915694-a9ee2980-8d71-11ea-8fc5-246413a4951d.png"> Closes apache#28439 from iRakson/streamingPagination. Authored-by: iRakson <[email protected]> Signed-off-by: Kousuke Saruta <[email protected]>
Contributor
Author
|
cc @sarutak Kindly take a look. |
|
Test build #123614 has finished for PR 28748 at commit
|
Contributor
Author
|
retest this please |
|
Test build #123620 has finished for PR 28748 at commit
|
Contributor
Author
|
cc @srowen I forgot to cc you |
sarutak
reviewed
Jun 8, 2020
| // Check batch tables | ||
| val h4Text = findAll(cssSelector("h4")).map(_.text).toSeq | ||
| h4Text.exists(_.matches("Active Batches \\(\\d+\\)")) should be (true) | ||
| h4Text.exists(_.matches("Completed Batches \\(last \\d+ out of \\d+\\)")) should be (true) |
Member
There was a problem hiding this comment.
Is this still flaky isn't it? What if it reaches this line before at least one batch finishes?
Contributor
Author
There was a problem hiding this comment.
It should be fine now. In 2nd attempt it should get at least 1 complete batch. As second attempt is after 500 ms and batches are of 100 ms only.
Contributor
Author
|
@sarutak gentle ping |
iRakson
changed the title
Member
|
Seems OK to me. |
sarutak
approved these changes
Jun 12, 2020
Member
|
Merged to master |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#28747 reverted #28439 due to some flaky test case. This PR fixes the flaky test and adds pagination support.
Why are the changes needed?
To support pagination for streaming tab
Does this PR introduce any user-facing change?
Yes, Now streaming tab tables will be paginated.
How was this patch tested?
Manually.