Skip to content

Conversation

@williamhyun
Copy link
Member

@williamhyun williamhyun commented May 31, 2020

What changes were proposed in this pull request?

This PR aims to upgrade to Zstd 1.4.5.

Why are the changes needed?

Zstd 1.4.5 improves performance.

https://github.com/facebook/zstd/releases/tag/v1.4.5

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Passed the Jenkins.

@williamhyun williamhyun changed the title Use Zstd 1.4.5 [SPARK-XXX][BUILD] Upgrade to Ztd 1.4.5 May 31, 2020
@williamhyun williamhyun changed the title [SPARK-XXX][BUILD] Upgrade to Ztd 1.4.5 [SPARK-XXX][BUILD] Upgrade to Zstd 1.4.5 May 31, 2020
@SparkQA
Copy link

SparkQA commented May 31, 2020

Test build #123329 has finished for PR 28682 at commit 3de543c.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@HyukjinKwon
Copy link
Member

@williamhyun Can you file a JIRA?

@SparkQA
Copy link

SparkQA commented May 31, 2020

Test build #123344 has finished for PR 28682 at commit 3de543c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@williamhyun williamhyun changed the title [SPARK-XXX][BUILD] Upgrade to Zstd 1.4.5 [SPARK-31876][BUILD] Upgrade to Zstd 1.4.5 May 31, 2020
@williamhyun
Copy link
Member Author

Sure, I filed SPARK-31876 and updated the PR title.

@srowen
Copy link
Member

srowen commented Jun 1, 2020

Looks OK if there are no compatibility concerns.

@dbtsai
Copy link
Member

dbtsai commented Jun 2, 2020

LGTM. Merged into master.

@dbtsai dbtsai closed this in 367d94a Jun 2, 2020
holdenk pushed a commit to holdenk/spark that referenced this pull request Oct 27, 2020
### What changes were proposed in this pull request?

This PR aims to upgrade to Zstd 1.4.5.

### Why are the changes needed?

Zstd 1.4.5 improves performance.

https://github.com/facebook/zstd/releases/tag/v1.4.5

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Passed the Jenkins.

Closes apache#28682 from williamhyun/zstd.

Authored-by: William Hyun <[email protected]>
Signed-off-by: DB Tsai <[email protected]>
otterc pushed a commit to linkedin/spark that referenced this pull request Mar 22, 2023
This PR aims to upgrade to Zstd 1.4.5.

Zstd 1.4.5 improves performance.

https://github.com/facebook/zstd/releases/tag/v1.4.5

No.

Passed the Jenkins.

Closes apache#28682 from williamhyun/zstd.

Authored-by: William Hyun <[email protected]>
Signed-off-by: DB Tsai <[email protected]>
(cherry picked from commit 367d94a)

RB=3332514
BUG=LIHADOOP-63952
G=spark-reviewers
R=tgudivad,ekrogen
A=ekrogen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants