[SPARK-31658][SQL] Fix SQL UI not showing write commands of AQE plan #28474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
force-pushed
the
aqe-ui
branch
3 times, most recently
from
1bd68c3 to
edc40ea
Compare
cloud-fan
reviewed
May 7, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
Show resolved
Hide resolved
Contributor
|
ok to test |
Contributor
maryannxue
reviewed
May 7, 2020
| context.session.sparkContext.listenerBus.post(SparkListenerSQLAdaptiveSQLMetricUpdates( | ||
| executionId.toLong, newMetrics)) | ||
| } else { | ||
| val queryExecution = SQLExecution.getQueryExecution(executionId) |
Contributor
There was a problem hiding this comment.
Use context.qe instead??
|
Test build #122405 has finished for PR 28474 at commit
|
Member
Author
|
@cloud-fan @maryannxue updated. Please review again. |
|
Test build #122422 has finished for PR 28474 at commit
|
cloud-fan
reviewed
May 8, 2020
| context.session.sparkContext.listenerBus.post(SparkListenerSQLAdaptiveSQLMetricUpdates( | ||
| executionId.toLong, newMetrics)) | ||
| } else { | ||
| val queryExecution = context.qe |
Contributor
There was a problem hiding this comment.
note: queryExecution is longer than context.qe, we can just inline it.
cloud-fan
approved these changes
May 8, 2020
|
Test build #122427 has finished for PR 28474 at commit
|
Member
|
retest this please |
|
Test build #122432 has finished for PR 28474 at commit
|
cloud-fan
changed the title
|
Test build #122439 has finished for PR 28474 at commit
|
maryannxue
reviewed
May 8, 2020
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #122442 has finished for PR 28474 at commit
|
Member
|
Thanks! Merged to master/3.0 |
gatorsmile
added a commit
that referenced
this pull request
May 8, 2020
Show write commands on SQL UI of an AQE plan Currently the leaf node of an AQE plan is always a `AdaptiveSparkPlan` which is not true when it's a child of a write command. Hence, the node of the write command as well as its metrics are not shown on the SQL UI.   No Add UT. Closes #28474 from manuzhang/aqe-ui. Lead-authored-by: manuzhang <[email protected]> Co-authored-by: Xiao Li <[email protected]> Signed-off-by: gatorsmile <[email protected]> (cherry picked from commit 77c690a) Signed-off-by: gatorsmile <[email protected]>
|
Test build #122443 has finished for PR 28474 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Show write commands on SQL UI of an AQE plan
Why are the changes needed?
Currently the leaf node of an AQE plan is always a
AdaptiveSparkPlanwhich is not true when it's a child of a write command. Hence, the node of the write command as well as its metrics are not shown on the SQL UI.Before
After
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add UT.