[SPARK-31638][WEBUI]Clean Pagination code for all webUI pages #28448
Conversation
iRakson
changed the title
iRakson
changed the title
|
cc @srowen @dongjoon-hyun @HyukjinKwon Kindly Review |
|
Jenkins test this please |
|
Test build #122289 has finished for PR 28448 at commit
|
|
I'll check within a week. |
| store, | ||
| data, | ||
| basePath, | ||
| currentTime, |
There was a problem hiding this comment.
If we can remove currentTime here, can we also remove currentTime from JobPagedTable?
There was a problem hiding this comment.
yeah. It can be removed. Thanks.
|
|
||
| override val dataSource: TaskDataSource = new TaskDataSource( | ||
| stage, | ||
| currentTime, |
There was a problem hiding this comment.
Similar to the comment for AllJobsPage, can we remove currentTime from TaskPagedTable?
| </span> | ||
| } | ||
| } | ||
| <span data-toggle="tooltip" data-placement="top" title={tooltip.getOrElse("")}> |
There was a problem hiding this comment.
Nice catch. Tooltips with zero-length titles are never displayed.
|
There is a bunch of code which is being copied whenever we implement pagination as pointed out here. I am thinking of making some changes to |
|
Up to your judgment about whether they can be logically broken up into separate changes that are easier to reason about, or go together. |
iRakson
force-pushed
the
refactorPagination
branch
from
9fdec71 to
d379a86
Compare
|
retest this please |
|
retest this please. |
|
Test build #123036 has finished for PR 28448 at commit
|
|
Merged to master |
4 participants
What changes were proposed in this pull request?
Pagination code across pages needs to be cleaned.
I have tried to clear out these things :
ifexpressionsWhy are the changes needed?
This fix will make code more readable and remove unnecessary methods and variables.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually