[SPARK-31267][SQL] Flaky test: WholeStageCodegenSparkSubmitSuite.Generated code on driver should not embed platform-specific constant #28438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
|
Test build #122222 has finished for PR 28438 at commit
|
Contributor
Author
Member
|
Thanks for the work, @tianshizz . btw, have you checked a root cause of the flaky failure is just a timeout, e.g., from jenkins logs? If that's true, the fix looks fine. |
Contributor
Author
|
@maropu I'm not able to see the jenkins log, but I was able to reproduce it on my own laptop, which is quite slow... It needs 1.5 - 2 minutes to finish that test. After increasing the timeout to 3 minutes, it can pass. |
Member
|
retest this please |
maropu
approved these changes
May 4, 2020
Member
|
Could you put the info |
|
Test build #122238 has finished for PR 28438 at commit
|
HyukjinKwon
approved these changes
May 4, 2020
HyukjinKwon
pushed a commit
that referenced
this pull request
May 4, 2020
…rated code on driver should not embed platform-specific constant ### What changes were proposed in this pull request? Allow customized timeouts for `runSparkSubmit`, which will make flaky tests more likely to pass by using a larger timeout value. I was able to reproduce the test failure on my laptop, which took 1.5 - 2 minutes to finish the test. After increasing the timeout, the test now can pass locally. ### Why are the changes needed? This allows slow tests to use a larger timeout, so they are more likely to succeed. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The test was able to pass on my local env after the change. Closes #28438 from tianshizz/SPARK-31267. Authored-by: Tianshi Zhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit a222644) Signed-off-by: HyukjinKwon <[email protected]>
Member
|
Merged to master and branch-3.0. |
huaxingao
pushed a commit
to huaxingao/spark
that referenced
this pull request
May 4, 2020
…rated code on driver should not embed platform-specific constant ### What changes were proposed in this pull request? Allow customized timeouts for `runSparkSubmit`, which will make flaky tests more likely to pass by using a larger timeout value. I was able to reproduce the test failure on my laptop, which took 1.5 - 2 minutes to finish the test. After increasing the timeout, the test now can pass locally. ### Why are the changes needed? This allows slow tests to use a larger timeout, so they are more likely to succeed. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The test was able to pass on my local env after the change. Closes apache#28438 from tianshizz/SPARK-31267. Authored-by: Tianshi Zhu <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Allow customized timeouts for
runSparkSubmit, which will make flaky tests more likely to pass by using a larger timeout value.I was able to reproduce the test failure on my laptop, which took 1.5 - 2 minutes to finish the test. After increasing the timeout, the test now can pass locally.
Why are the changes needed?
This allows slow tests to use a larger timeout, so they are more likely to succeed.
Does this PR introduce any user-facing change?
No
How was this patch tested?
The test was able to pass on my local env after the change.