Skip to content

[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite #28427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite #28427

wants to merge 2 commits into from

Conversation

@maropu
Copy link
Member

@maropu maropu commented May 1, 2020 •
edited
Loading

What changes were proposed in this pull request?

This PR is a follow-up PR to update the golden file of ExpressionsSchemaSuite.

Why are the changes needed?

To recover tests in branch-3.0.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@maropu maropu mentioned this pull request May 1, 2020
Closed
@maropu
Copy link
Member Author

maropu commented May 1, 2020

cc: @dongjoon-hyun

@maropu maropu changed the title [SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of byExpressionsSchemaSuite [SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of ExpressionsSchemaSuite May 1, 2020
HyukjinKwon
HyukjinKwon approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix. LGTM

@maropu
Copy link
Member Author

maropu commented May 1, 2020

Thanks for the quick response, @HyukjinKwon ;)

cloud-fan
cloud-fan approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@beliefer
Copy link
Contributor

beliefer commented May 1, 2020

@maropu, It seems we not change the schema of rand() in branch-3.0? Why we preserve the distinguish between master and branch-3.0 ?

@maropu
Copy link
Member Author

maropu commented May 1, 2020

Ah, yes. We need to ignore them in branch-3.0. I'll update.

@SparkQA
Copy link

SparkQA commented May 1, 2020

Test build #122155 has finished for PR 28427 at commit 948a54e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon
HyukjinKwon reviewed May 1, 2020
View reviewed changes
sql/core/src/test/resources/sql-functions/sql-expression-schema.md
| org.apache.spark.sql.catalyst.expressions.RLike | rlike | SELECT '%SystemDrive%\Users\John' rlike '%SystemDrive%\\Users.*' | struct<%SystemDrive%UsersJohn RLIKE %SystemDrive%\Users.*:boolean> |
| org.apache.spark.sql.catalyst.expressions.Rand | random | SELECT random() | struct<rand():double> |
| org.apache.spark.sql.catalyst.expressions.Rand | rand | SELECT rand() | struct<rand():double> |
| org.apache.spark.sql.catalyst.expressions.Randn | randn | SELECT randn() | struct<randn():double> |
Copy link
Member

@HyukjinKwon HyukjinKwon May 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @beliefer meant #28392 is only landed into master and we should keep these just as are at #28194. I assume rand(seed) was printed out because this test was ran against the latest master instead of branch-3.0 at 948a54e (?).

Copy link
Member Author

@maropu maropu May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I think this golden file was generated in master, so I re-generated it in branch-3.0. Btw, we need this test suite in branch-3.0? Reverting #28194 from branch-3.0 is another simple solution to recover it, I think.

Copy link
Contributor

@cloud-fan cloud-fan May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is useful to track the auto-alias name change history. It would be nice to have it in 3.0.

@SparkQA
Copy link

SparkQA commented May 1, 2020

Test build #122158 has finished for PR 28427 at commit db16f76.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented May 1, 2020

Thanks, all. Merged to branch-3.0.

@maropu maropu closed this May 1, 2020
maropu added a commit that referenced this pull request May 1, 2020
@maropu
[SPARK-31372][SQL][TEST][FOLLOWUP][3.0] Update the golden file of Exp…
7c6b970 
…ressionsSchemaSuite

### What changes were proposed in this pull request?

This PR is a follow-up PR to update the golden file of `ExpressionsSchemaSuite`.

### Why are the changes needed?

To recover tests in branch-3.0.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests.

Closes #28427 from maropu/SPARK-31372-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented May 1, 2020 •
edited
Loading

+1, late LGTM. Thank you for quick fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloud-fan cloud-fan cloud-fan approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@maropu @beliefer @SparkQA @dongjoon-hyun @cloud-fan @HyukjinKwon