Skip to content

Conversation

@huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Apr 30, 2020

What changes were proposed in this pull request?

SQL Reference cleanup

Why are the changes needed?

To complete SQL Reference

Does this PR introduce any user-facing change?

Fix the following stuff:

  • Example -> Examples
  • SET DBPROPERTIES ( property_name = property_value, ... ) -> SET DBPROPERTIES ( property_name = property_value [ , ... ] )
    // be consistent with format. brackets [ and ] indicate optional parts, and dots ... mean that the
    // preceding element can be repeated.
  • col_spec [ , col_spec ... ] -> col_spec [ , ... ] // same as above, be consistent with format.
  • [USING data_source] -> [ USING data_source ] // be consistent with format. space between [ and text
  • change function_name format to make it consistent with others
  • from -> FROM // uppercase keyword
  • { { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] } | query } -> { VALUES ( { value | NULL } [ , ... ] ) [ , ( ... ) ] | query } // remove unnecessary { }
  • DROP ( DATABASE | SCHEMA ) -> DROP { DATABASE | SCHEMA }
    // Braces { and } and vertical lines | indicate that you must choose one alternative
  • fix a few link and typo too.

Also updated sql-ref-syntax-qry.html

before
Screen Shot 2020-04-29 at 11 08 25 PM

after
Screen Shot 2020-04-29 at 11 05 55 PM

How was this patch tested?

Manually build and check

@huaxingao
Copy link
Contributor Author

cc @gatorsmile @maropu
In the first round of clean-up, I will focus on syntax and typos. After I finish this, I will remove all the html syntax following this PR #28414. Then change HTML tables to MD tables following this PR #28415
I have added a couple of <code> </code> in this PR, because when I did this, I didn't know we will remove html syntax. I will just leave these <code> </code>, will remove all the html syntax in the second round of clean-up.

@SparkQA
Copy link

SparkQA commented Apr 30, 2020

Test build #122109 has finished for PR 28417 at commit 92bda1b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 30, 2020

Test build #122114 has finished for PR 28417 at commit 5b8b221.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu maropu closed this in 2410a45 Apr 30, 2020
maropu pushed a commit that referenced this pull request Apr 30, 2020
### What changes were proposed in this pull request?
SQL Reference cleanup

### Why are the changes needed?
To complete SQL Reference

### Does this PR introduce _any_ user-facing change?
updated sql-ref-syntax-qry.html

before
<img width="1100" alt="Screen Shot 2020-04-29 at 11 08 25 PM" src="https://user-images.githubusercontent.com/13592258/80677799-70b27280-8a6e-11ea-8e3f-a768f29d0377.png">

after
<img width="1100" alt="Screen Shot 2020-04-29 at 11 05 55 PM" src="https://user-images.githubusercontent.com/13592258/80677803-74de9000-8a6e-11ea-880c-aa05c53254a6.png">

### How was this patch tested?
Manually build and check

Closes #28417 from huaxingao/cleanup.

Authored-by: Huaxin Gao <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
(cherry picked from commit 2410a45)
Signed-off-by: Takeshi Yamamuro <[email protected]>
@maropu
Copy link
Member

maropu commented Apr 30, 2020

Thanks! Merged to master/3.0.

@huaxingao
Copy link
Contributor Author

Thanks! @maropu @srowen

@huaxingao huaxingao deleted the cleanup branch April 30, 2020 21:34
@maropu
Copy link
Member

maropu commented Apr 30, 2020

Ur, plz add what's cleaned up in the PR description (& the jira).

@huaxingao
Copy link
Contributor Author

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants