[SPARK-31586][SQL] Replace expression TimeSub(l, r) with TimeAdd(l -r) #28381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #121946 has finished for PR 28381 at commit
|
Member
Author
|
retest this please |
Member
Author
|
cc @cloud-fan, please also notice that the flakiness of CliSuite is still there according the test failure above. |
|
Test build #121960 has finished for PR 28381 at commit
|
Member
Author
|
retest this please |
cloud-fan
approved these changes
Apr 28, 2020
|
Test build #121972 has finished for PR 28381 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The implementation of TimeSub for the operation of timestamp subtracting interval is almost repetitive with TimeAdd. We can replace it with TimeAdd(l, -r) since there are equivalent.
Suggestion from #28310 (comment)
Besides, the Coercion rules for TimeAdd/TimeSub(date, interval) are useless anymore, so remove them in this PR since they are touched in this PR.
Why are the changes needed?
remove redundant and useless code for easy maintenance
Does this PR introduce any user-facing change?
Yes, the SQL string of
datetime - intervalbecomedatetime + (- interval)How was this patch tested?
modified existing unit tests.