[SPARK-31532][SPARK-31234][SQL][2.4][FOLLOWUP] Use lowercases for GLOBAL_TEMP_DATABASE config in SparkSessionBuilderSuite #28339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
Thank you, @maropu ! |
yaooqinn
approved these changes
Apr 25, 2020
| val session = SparkSession.builder() | ||
| .master("local") | ||
| .config(GLOBAL_TEMP_DATABASE.key, value = "globalTempDB-SPARK-31234") | ||
| .config(GLOBAL_TEMP_DATABASE.key, value = "globaltempdb-spark-31234") |
Member
There was a problem hiding this comment.
Now, I understand why you change the conf. This one is the safest test case change in branch-2.4.
Member
Author
There was a problem hiding this comment.
Need this one? Dropping this is okay to me though.
dongjoon-hyun
approved these changes
Apr 25, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for the swift fix.
I ran the test locally. I'll merge this to recover branch-2.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 25, 2020
…BAL_TEMP_DATABASE config in SparkSessionBuilderSuite ### What changes were proposed in this pull request? This PR intends to fix test code for using lowercases for the `GLOBAL_TEMP_DATABASE` config in `SparkSessionBuilderSuite`. The handling of the config is different between branch-3.0+ and branch-2.4. In branch-3.0+, Spark always lowercases a value in the config, so I think we had better always use lowercases for it in the test. This comes from the dongjoon-hyun comment: #28316 (comment) ### Why are the changes needed? To fix the test failure in branch-2.4. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Fixed the test. Closes #28339 from maropu/SPARK-31532. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
Author
|
Thanks for the quick response, @dongjoon-hyun ! |
|
Test build #121794 has finished for PR 28339 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR intends to fix test code for using lowercases for the
GLOBAL_TEMP_DATABASEconfig inSparkSessionBuilderSuite. The handling of the config is different between branch-3.0+ and branch-2.4. In branch-3.0+, Spark always lowercases a value in the config, so I think we had better always use lowercases for it in the test.This comes from the @dongjoon-hyun
comment: #28316 (comment)
Why are the changes needed?
To fix the test failure in branch-2.4.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Fixed the test.