[SPARK-31234][SQL][2.4] ResetCommand should not affect static SQL Configuration #28262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
|
cc @holdenk since she is the release manager of 2.4.6 and the target version of this issue became 2.4.6 today. |
gatorsmile
commented
Apr 19, 2020
| assert(session.sessionState.conf.getConf(GLOBAL_TEMP_DATABASE) === "globalTempDB-SPARK-31234") | ||
| session.sql("RESET") | ||
| assert(session.sessionState.conf.getConfString("spark.app.name") === "test-app-SPARK-31234") | ||
| assert(session.sessionState.conf.getConf(GLOBAL_TEMP_DATABASE) === "globalTempDB-SPARK-31234") |
Member
Author
There was a problem hiding this comment.
GLOBAL_TEMP_DATABASE is a typical example. The value is being used at the runtime. See the code
dongjoon-hyun
approved these changes
Apr 19, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending Jenkins). Thanks, @gatorsmile .
|
Test build #121483 has finished for PR 28262 at commit
|
Member
|
Merged to branch-2.4. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Apr 19, 2020
…figuration ### What changes were proposed in this pull request? This PR is to backport the fix of #28003, add a migration guide, update the PR description and add an end-to-end test case. Before this PR, the SQL `RESET` command will reset the values of static SQL configuration to the default and remove the cached values of Spark Context Configurations in the current session. This PR fixes the bugs. After this PR, the `RESET` command follows its definition and only updates the runtime SQL configuration values to the default. ### Why are the changes needed? When we introduced the feature of Static SQL Configuration, we did not update the implementation of SQL `RESET` command. The static SQL configuration should not be changed by any command at runtime. However, the `RESET` command resets the values to the default. We should fix them. ### Does this PR introduce any user-facing change? Before Spark 2.4.6, the `RESET` command resets both the runtime and static SQL configuration values to the default. It also removes the cached values of Spark Context Configurations in the current session, although these configuration values are for displaying/querying only. ### How was this patch tested? Added an end-to-end test and a unit test Closes #28262 from gatorsmile/spark-31234followup2.4. Authored-by: gatorsmile <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Looks fine, thanks, @gatorsmile ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to backport the fix of #28003, add a migration guide, update the PR description and add an end-to-end test case.
Before this PR, the SQL
RESETcommand will reset the values of static SQL configuration to the default and remove the cached values of Spark Context Configurations in the current session. This PR fixes the bugs. After this PR, theRESETcommand follows its definition and only updates the runtime SQL configuration values to the default.Why are the changes needed?
When we introduced the feature of Static SQL Configuration, we did not update the implementation of SQL
RESETcommand.The static SQL configuration should not be changed by any command at runtime. However, the
RESETcommand resets the values to the default. We should fix them.Does this PR introduce any user-facing change?
Before Spark 2.4.6, the
RESETcommand resets both the runtime and static SQL configuration values to the default. It also removes the cached values of Spark Context Configurations in the current session, although these configuration values are for displaying/querying only.How was this patch tested?
Added an end-to-end test and a unit test