[SPARK-31186][PySpark][SQL][2.4] toPandas should not fail on duplicate column names #28219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #121294 has finished for PR 28219 at commit
|
|
Test build #121295 has finished for PR 28219 at commit
|
|
Test build #121298 has finished for PR 28219 at commit
|
Member
|
Thanks @viirya. Merged to branch-2.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Apr 15, 2020
…e column names ### What changes were proposed in this pull request? When `toPandas` API works on duplicate column names produced from operators like join, we see the error like: ``` ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all(). ``` This patch fixes the error in `toPandas` API. This is the backport of original patch to branch-2.4. ### Why are the changes needed? To make `toPandas` work on dataframe with duplicate column names. ### Does this PR introduce any user-facing change? Yes. Previously calling `toPandas` API on a dataframe with duplicate column names will fail. After this patch, it will produce correct result. ### How was this patch tested? Unit test. Closes #28219 from viirya/SPARK-31186-2.4. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Member
|
cc @ueshin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
toPandasAPI works on duplicate column names produced from operators like join, we see the error like:This patch fixes the error in
toPandasAPI.This is the backport of original patch to branch-2.4.
Why are the changes needed?
To make
toPandaswork on dataframe with duplicate column names.Does this PR introduce any user-facing change?
Yes. Previously calling
toPandasAPI on a dataframe with duplicate column names will fail. After this patch, it will produce correct result.How was this patch tested?
Unit test.