[SPARK-31305][SQL][DOCS] Add a page to list all commands in SQL Reference #28074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #120602 has finished for PR 28074 at commit
|
|
Test build #120605 has finished for PR 28074 at commit
|
maropu
reviewed
Mar 31, 2020
docs/sql-ref-syntax.md
Outdated
| Spark SQL is Apache Spark's module for working with structured data. The SQL Syntax section describes the SQL syntax in detail along with usage examples when applicable. | ||
| Spark SQL is Apache Spark's module for working with structured data. The SQL Syntax section describes the SQL syntax in detail along with usage examples when applicable. This document provides a list of Data Definition and Data Manipulation Statements, as well as Data Retrieval and Auxiliary Statements. | ||
|
|
||
| ### Data Definition Statements |
Member
There was a problem hiding this comment.
How about DDL Statements for consistency? https://github.com/apache/spark/blob/master/docs/sql-migration-guide.md#ddl-statements
maropu
reviewed
Mar 31, 2020
docs/sql-ref-syntax.md
Outdated
| - [TRUNCATE TABLE](sql-ref-syntax-ddl-truncate-table.html) | ||
| - [USE DATABASE](sql-ref-syntax-qry-select-usedb.html) | ||
|
|
||
| ### Data Manipulation Statements |
maropu
reviewed
Mar 31, 2020
| - [LIMIT Clause](sql-ref-syntax-qry-select-limit.html) | ||
| - [ORDER BY Clause](sql-ref-syntax-qry-select-orderby.html) | ||
| - [SORT BY Clause](sql-ref-syntax-qry-select-sortby.html) | ||
| - [WHERE Clause](sql-ref-syntax-qry-select-where.html) |
Member
There was a problem hiding this comment.
We need these links to the sub-categoris of SELECT? Just linking to sql-ref-syntax-qry-select.md here is not enough?
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment. I want to list all the sql statements on one page, so I prefer to have all the links here.
|
Test build #120624 has finished for PR 28074 at commit
|
Contributor
Author
|
@srowen This is for 3.0. Thank you! |
srowen
approved these changes
Mar 31, 2020
maropu
approved these changes
Mar 31, 2020
maropu
pushed a commit
that referenced
this pull request
Mar 31, 2020
…ence ### What changes were proposed in this pull request? Add a page to list all commands in SQL Reference... ### Why are the changes needed? so it's easier for user to find a specific command. ### Does this PR introduce any user-facing change? before:  after:   Also move ```use database``` from query category to ddl category. ### How was this patch tested? Manually build and check Closes #28074 from huaxingao/list-all. Authored-by: Huaxin Gao <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit 1a7f964) Signed-off-by: Takeshi Yamamuro <[email protected]>
Member
|
Thanks, @huaxingao ! Merged to master/3.0. btw, have we done all the works about the SQL references? It seems the RC1 for 3.0 will be started in a few days. |
Contributor
Author
|
Thanks! @maropu @srowen |
Member
|
ok, thanks for the work! cc: @dongjoon-hyun |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ence ### What changes were proposed in this pull request? Add a page to list all commands in SQL Reference... ### Why are the changes needed? so it's easier for user to find a specific command. ### Does this PR introduce any user-facing change? before:  after:   Also move ```use database``` from query category to ddl category. ### How was this patch tested? Manually build and check Closes apache#28074 from huaxingao/list-all. Authored-by: Huaxin Gao <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a page to list all commands in SQL Reference...
Why are the changes needed?
so it's easier for user to find a specific command.
Does this PR introduce any user-facing change?
before:
after:
Also move
use databasefrom query category to ddl category.How was this patch tested?
Manually build and check