[SPARK-31229][SQL][TESTS] Add unit tests TypeCoercion.findTypeForComplex and Cast.canCast in null <> complex types #27990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
SPARK-31166-followup
branch
from
ce0d668 to
e6d3c6f
Compare
|
Test build #120202 has finished for PR 27990 at commit
|
|
Test build #120203 has finished for PR 27990 at commit
|
Member
Author
|
retest this please |
|
Test build #120200 has finished for PR 27990 at commit
|
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Mar 23, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (with only one nit for indentation).
|
Test build #120210 has finished for PR 27990 at commit
|
Member
|
Retest this please. |
|
Test build #120218 has finished for PR 27990 at commit
|
Member
|
retest this please |
maropu
approved these changes
Mar 23, 2020
|
Test build #120221 has finished for PR 27990 at commit
|
|
Test build #120224 has finished for PR 27990 at commit
|
Member
Author
|
Let me just merge this - there's nothing related to pip packing test .. Merged to master and branch-3.0. Thanks, @dongjoon-hyun and @maropu |
HyukjinKwon
added a commit
that referenced
this pull request
Mar 24, 2020
…lex and Cast.canCast in null <> complex types ### What changes were proposed in this pull request? This PR (SPARK-31229) is rather a followup of #27926 (SPARK-31166). It adds unittests for `TypeCoercion.findTypeForComplex` and `Cast.canCast` about struct, map and array with the respect to null types. ### Why are the changes needed? To detect which scope was broken in the future easily. ### Does this PR introduce any user-facing change? No, it's a test-only. ### How was this patch tested? Unittests were added. Closes #27990 from HyukjinKwon/SPARK-31166-followup. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit bd32400) Signed-off-by: HyukjinKwon <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…lex and Cast.canCast in null <> complex types ### What changes were proposed in this pull request? This PR (SPARK-31229) is rather a followup of apache#27926 (SPARK-31166). It adds unittests for `TypeCoercion.findTypeForComplex` and `Cast.canCast` about struct, map and array with the respect to null types. ### Why are the changes needed? To detect which scope was broken in the future easily. ### Does this PR introduce any user-facing change? No, it's a test-only. ### How was this patch tested? Unittests were added. Closes apache#27990 from HyukjinKwon/SPARK-31166-followup. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR (SPARK-31229) is rather a followup of #27926 (SPARK-31166). It adds unittests for
TypeCoercion.findTypeForComplexandCast.canCastabout struct, map and array with the respect to null types.Why are the changes needed?
To detect which scope was broken in the future easily.
Does this PR introduce any user-facing change?
No, it's a test-only.
How was this patch tested?
Unittests were added.