[SPARK-31159][SQL][FOLLOWUP] Move checking of the rebaseDateTime flag out of the loop in VectorizedColumnReader
#27973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
ping @HyukjinKwon |
|
Test build #120115 has finished for PR 27973 at commit
|
HyukjinKwon
approved these changes
Mar 23, 2020
HyukjinKwon
reviewed
Mar 23, 2020
| long micros = DateTimeUtils.millisToMicros(dataColumn.readLong()); | ||
| if (rebaseDateTime) { | ||
| micros = DateTimeUtils.rebaseJulianToGregorianMicros(micros); | ||
| if (rebaseDateTime) { |
Member
There was a problem hiding this comment.
I am kind of neutral but a bit of dups vs a bit of perf :-). I guess it's fine.
HyukjinKwon
pushed a commit
that referenced
this pull request
Mar 23, 2020
…ag out of the loop in `VectorizedColumnReader` In the PR, I propose to refactor reading of timestamps of the `TIMESTAMP_MILLIS` logical type from Parquet files in `VectorizedColumnReader`, and move checking of the `rebaseDateTime` flag out of the internal loop. To avoid any additional overhead of the checking the SQL config `spark.sql.legacy.parquet.rebaseDateTime.enabled` introduced by the PR #27915. No By running the test suite `ParquetIOSuite`. Closes #27973 from MaxGekk/rebase-parquet-datetime-followup. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit aa3a742) Signed-off-by: HyukjinKwon <[email protected]>
Member
|
Merged to master and branch-3.0. |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ag out of the loop in `VectorizedColumnReader` ### What changes were proposed in this pull request? In the PR, I propose to refactor reading of timestamps of the `TIMESTAMP_MILLIS` logical type from Parquet files in `VectorizedColumnReader`, and move checking of the `rebaseDateTime` flag out of the internal loop. ### Why are the changes needed? To avoid any additional overhead of the checking the SQL config `spark.sql.legacy.parquet.rebaseDateTime.enabled` introduced by the PR apache#27915. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running the test suite `ParquetIOSuite`. Closes apache#27973 from MaxGekk/rebase-parquet-datetime-followup. Authored-by: Maxim Gekk <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to refactor reading of timestamps of the
TIMESTAMP_MILLISlogical type from Parquet files inVectorizedColumnReader, and move checking of therebaseDateTimeflag out of the internal loop.Why are the changes needed?
To avoid any additional overhead of the checking the SQL config
spark.sql.legacy.parquet.rebaseDateTime.enabledintroduced by the PR #27915.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the test suite
ParquetIOSuite.